Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

shell/gnrc_icmpv6_echo: acquire ZTIMER_USEC clock for time measurement #19055

Merged
merged 1 commit into from
Feb 2, 2023
Merged

shell/gnrc_icmpv6_echo: acquire ZTIMER_USEC clock for time measurement #19055

merged 1 commit into from
Feb 2, 2023

Conversation

jue89
Copy link
Contributor

@jue89 jue89 commented Dec 14, 2022

Contribution description

With the introduction of #17607, applications using ztimer_now() have to tell ztimer that it mustn't disable underlying clocks.

Testing procedure

Ping should work. No warnings shall be displayed if ztimer_ondemand is active.

Issues/PRs references

@github-actions github-actions bot added the Area: sys Area: System label Dec 14, 2022
@jue89 jue89 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: sys Area: System and removed Area: sys Area: System labels Dec 14, 2022
@benpicco benpicco requested a review from miri64 December 14, 2022 16:34
@riot-ci
Copy link

riot-ci commented Dec 14, 2022

Murdock results

✔️ PASSED

da41955 shell/gnrc_icmpv6_echo: acquire ZTIMER_USEC clock for time measurement

Success Failures Total Runtime
2006 0 2006 04m:34s

Artifacts

@benpicco benpicco requested review from kaspar030 and kfessel January 24, 2023 17:27
benpicco
benpicco approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@benpicco
Copy link
Contributor

bors merge

1 similar comment
@benpicco
Copy link
Contributor

benpicco commented Feb 2, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 2, 2023

Build succeeded:

@bors bors bot merged commit a9dbf8b into RIOT-OS:master Feb 2, 2023
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@kfessel kfessel Awaiting requested review from kfessel

Assignees
No one assigned
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@jue89 @riot-ci @benpicco @MrKevinWeiss