cpu/sam0_common: move adc_res_t to common code #19164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
the
Impact: minor
github-actions
bot
added
Area: cpu
benpicco
added
CI: ready for build
dylad
approved these changes
Jan 18, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 18, 2023
18100: core/assert: print backtrace on failed assertion r=benpicco a=benpicco 19121: socket_zep: only report size of single datagram r=miri64 a=benpicco 19164: cpu/sam0_common: move adc_res_t to common code r=dylad a=benpicco 19169: tests/driver_ws281x: don't overwrite board definition r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de>
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
added a commit
that referenced
this pull request
Jan 18, 2023
18100: core/assert: print backtrace on failed assertion r=kaspar030 a=benpicco 19121: socket_zep: only report size of single datagram r=miri64 a=benpicco 19164: cpu/sam0_common: move adc_res_t to common code r=dylad a=benpicco 19169: tests/driver_ws281x: don't overwrite board definition r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
adc_res_tis the same across all family members, so move it to common code.This will help extending it as a follow-up.
Also move to
bit.RESSELaccess instead of masking the whole register to make the code more readable.Testing procedure
Issues/PRs references