Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pkg/libfixmath: bump version #19182

Merged
merged 3 commits into from
Jan 22, 2023
Merged

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jan 20, 2023

Contribution description

Custom patches are no longer needed.

We can also avoid patching the unit tests by providing a callback function on main() exit (the unit tests provide their own main() function that returns 0 on success and 1 on failure).

Testing procedure

Ran tests/pkg_libfixmath both on native and on avr-rss2 (AVR).

Issues/PRs references

custom patches are no longer needed
@github-actions github-actions bot added the Area: pkg Area: External package ports label Jan 20, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 20, 2023
@benpicco benpicco requested review from aabadie and bergzand January 20, 2023 14:15
@riot-ci
Copy link

riot-ci commented Jan 20, 2023

Murdock results

✔️ PASSED

d102723 tests/pkg_libfixmath_unittests: adapt test to upstream changes

Success Failures Total Runtime
6782 0 6782 09m:59s

Artifacts

@github-actions github-actions bot added Area: build system Area: Build system Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: tests Area: tests and testing framework labels Jan 20, 2023
@benpicco benpicco requested a review from maribu January 22, 2023 00:58
@maribu
Copy link
Member

maribu commented Jan 22, 2023

bors merge

bors bot added a commit that referenced this pull request Jan 22, 2023
19182: pkg/libfixmath: bump version r=maribu a=benpicco



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
@maribu
Copy link
Member

maribu commented Jan 22, 2023

bors cancel
bors merge

@bors
Copy link
Contributor

bors bot commented Jan 22, 2023

Canceled.

bors bot added a commit that referenced this pull request Jan 22, 2023
17735: examples/gcoap_dtls: Increase stack size r=maribu a=maribu

### Contribution description

As the title says. The stack size was copied over from `tests/pkg_tinydtls_sock_async` cargo-cult style. Also some typos in the README were fixed.

### Testing procedure

Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes.

### Issues/PRs references

None

19182: pkg/libfixmath: bump version r=maribu a=benpicco



19184: pkg/tinydtls: bump version r=maribu a=benpicco



Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
@bors
Copy link
Contributor

bors bot commented Jan 22, 2023

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Jan 22, 2023

Build succeeded:

@bors bors bot merged commit 4c4cb3a into RIOT-OS:master Jan 22, 2023
@benpicco benpicco deleted the pkg/libfixmath-bump branch January 22, 2023 12:53
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: build system Area: Build system Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants