-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
pkg/libfixmath: bump version #19182
Merged
Merged
pkg/libfixmath: bump version #19182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custom patches are no longer needed
Let's no longer patch the upstream test but use it directly
maribu
approved these changes
Jan 22, 2023
bors merge |
bors cancel |
Canceled. |
bors bot
added a commit
that referenced
this pull request
Jan 22, 2023
17735: examples/gcoap_dtls: Increase stack size r=maribu a=maribu ### Contribution description As the title says. The stack size was copied over from `tests/pkg_tinydtls_sock_async` cargo-cult style. Also some typos in the README were fixed. ### Testing procedure Previously on my Nucleo-F767ZI, the CoAP client triggered the MPU stack guard on sending the DTLS hello. With this, the board no longer crashes. ### Issues/PRs references None 19182: pkg/libfixmath: bump version r=maribu a=benpicco 19184: pkg/tinydtls: bump version r=maribu a=benpicco Co-authored-by: Marian Buschsieweke <marian.buschsieweke@ovgu.de> Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
Build failed (retrying...): |
Build succeeded: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Area: build system
Area: Build system
Area: core
Area: RIOT kernel. Handle PRs marked with this with care!
Area: pkg
Area: External package ports
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Custom patches are no longer needed.
We can also avoid patching the unit tests by providing a callback function on
main()
exit (the unit tests provide their ownmain()
function that returns 0 on success and 1 on failure).Testing procedure
Ran
tests/pkg_libfixmath
both onnative
and onavr-rss2
(AVR).Issues/PRs references