Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix SX126X-STM32WL module in Kconfig #19191

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Fix SX126X-STM32WL module in Kconfig #19191

merged 2 commits into from
Jan 24, 2023

Conversation

MrKevinWeiss
Copy link
Contributor

Contribution description

Master is broken due to kconfig mismatch for the nucleo-wl55jc. The radio was just not declared.

This fixes the board and cleans up some of the SX126X kconfig.

Testing procedure

Murdock should pass

Issues/PRs references

@MrKevinWeiss MrKevinWeiss requested a review from aabadie January 24, 2023 09:23
@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 24, 2023
@github-actions github-actions bot added Area: boards Area: Board ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support labels Jan 24, 2023
@MrKevinWeiss
Copy link
Contributor Author

Maybe this should just be selected but defaulted...

@riot-ci
Copy link

riot-ci commented Jan 24, 2023 •
edited
Loading

Murdock results

✔️ PASSED

75ece64 boards/nucleo-wl55jc: Expose sx126x in kconfig

Success Failures Total Runtime
6796 0 6796 11m:42s

Artifacts

kaspar030
kaspar030 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@MrKevinWeiss
Copy link
Contributor Author

squashed and ready. Still don't know why it passed and was merged, maybe it was excluded from a list at the time. Anyways, at least forward progress.

@MrKevinWeiss
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

Build succeeded:

@bors bors bot merged commit d1072c2 into RIOT-OS:master Jan 24, 2023
@MrKevinWeiss MrKevinWeiss deleted the pr/fixwl55 branch January 25, 2023 07:11
@MrKevinWeiss MrKevinWeiss mentioned this pull request Jan 25, 2023
Merged
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
3 participants
@MrKevinWeiss @riot-ci @kaspar030