tests/periph_flashpage_unittest: enable periph_flashpage #19215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
gschorcht
added
CI: ready for build
Testing the correct calculation of flash page indices without assuming the `periph_flashpage` feature and enabling the `periph_flashpage` module makes no sense. On ESP32x SoCs for example, the space in the flash is only reserved and `FLASHPAGE_NUMOF` is greater than 0 if `periph_flashpage` is used.
gschorcht
force-pushed
the
tests/fix_periph_flashpage_unittest
branch
from
7ceca89 to
04df8cd
Compare
|
CI RasPi are down, that test run will stall until fixed :/ |
|
Build succeeded: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR enables the
periph_flashpagemodule for the unittest intests/periph_flashpage_unittestso that it requires featureperiph_flashpageand expects only correct calculation of flashpage indices if it is used.Testing the correct calculation of flashpage indices without assuming the
periph_flashpagefeature and enabling theperiph_flashpagemodule makes no sense. On ESP32x SoCs for example, the space in the flash is only reserved andFLASHPAGE_NUMOFis greater than 0 ifperiph_flashpageis used.The PR fixes the unittest problem for ESP32x SoCs.
Testing procedure
Green CI with label
CI: run test.Issues/PRs references