Make: Add generate-Makefile.ci #19244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
added
Type: bug
maribu
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
Maybe we can also drop create-Makefile ci. I don't expect any downstream users (they would need a Murdock instance themselves), so I think we don't need a deprecation.
I hope @benpicco' s muscle memory adapts swiftly to the new name, otherwise he should speak up against the change quickly :)
|
Yea just remove the |
With this rename it is in line with the other generate-* targets
bergzand
force-pushed
the
pr/generate-Makefile.ci
branch
from
eb59f4d to
820a895
Compare
|
I took the liberty of force pushing a new commit with a rename instead of adding a new target. |
|
I also added a similar commit to #19245, making |
benpicco
added
CI: ready for build
|
bors merge |
|
Build succeeded: |
|
Thanks for the swift review |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is the same as the create-Makefile.ci. The alias is added to stay in line with other generate-* Make targets. Now the documentation should also be valid again
Testing procedure
The target should now match the documentation in the doxygen.
Issues/PRs references
follow-up to #19239