esptools/install.sh: Fix shellcheck issues #19325
Conversation
Quote all the things!
bergzand
added
Type: cleanup
github-actions
bot
removed
the
Platform: ESP
bergzand
added
the
CI: skip compile test
|
The same is probably needed for |
|
As long as the variables do not contain spaces, it should not really be necessary in any shell to enclose them in quotes. But indeed, for path names it is better to quote them. |
Yup, path names and argument should always be quoted as they could in theory contain whitespace. Variables, in this case |
To be honest this is a quick drive-by PR from me, so I'd rather handle that one in a follow up if you don't mind. |
|
Thanks for providing that fix. |
benpicco
added
the
CI: ready for build
|
bors merge |
19321: examples/gnrc_border_router: add BLE as downlink option r=benpicco a=benpicco 19325: esptools/install.sh: Fix shellcheck issues r=benpicco a=bergzand ### Contribution description Quote all the things! ### Testing procedure The script should still work as before ### Issues/PRs references None 19327: shell/cmds: GNRC: replace puts() with printf() r=benpicco a=benpicco 19328: pkg/u8g2: bump version r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Koen Zandberg <koen@bergzand.net> Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de>
|
Build failed (retrying...): |
|
bors cancel |
|
Canceled. |
|
Build succeeded: |
Contribution description
Quote all the things!
Testing procedure
The script should still work as before
Issues/PRs references
None