makefiles/tools/jlink.inc.mk: use ELF file for flashing

[maribu]

Contribution description

There seems to be a consensus to go for a more ELF centric approach whenever possible. J-Link seems to work fine with ELF files, so let's avoid the extra step to create a bin file from the ELF file prior to flashing.

Testing procedure

Flashing with J-Link should still just work

Issues/PRs references

In #19537 (comment) I was made aware that we use the bin file by default for J-Link flashing.

[dylad]

I am wondering if we should also update this file at the same time.
Since we used .bin file, we had to manually prepare the offset address to flash. But I don't know if it will have side effects, to specify an offset AND passing the .elf at the same time. the latter is supposed to contain this information already but I don't know if jlink command will ignore the offset argument then.
I'll run some tests tonight if I can.

[maribu]

Indeed, that shell script should be adapted to handle ELF files properly

[maribu]

I updated the script to handle both ELF and bin files. I tested both successfully with the nRF52840DK.

[maribu]

Rebased on master and dropped the now no longer needed FLASHFILE = $(ELFFILE).

[dylad]

I tested this PR on rpi-pico both with .elf file and .bin file (with IMAGE_OFFSET=0x10000000) and it works as expected.

[riot-ci]

Murdock results

✔️ PASSED

93561c7 boards/rpi-pico: ELF format now is default, cleanup

Success	Failures	Total	Runtime
6931	0	6931	10m:29s

Artifacts

• Documentation preview

[dylad]

bors merge

[bors]

Build failed:

• Murdock

[maribu]

bors merge

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• Murdock
• static-tests
• tools-build-success

[maribu]

Thx :)

[benpicco]

This breaks flashing nrf52840dk:

### Flashing Target ###
### Flashing elf file ###
SEGGER J-Link Commander V7.66b (Compiled May 30 2022 14:12:34)
DLL version V7.66b, compiled May 30 2022 14:12:19

J-Link Commander will now exit on Error

J-Link Command File read successfully.
Processing script file...
J-Link>loadfile /home/benpicco/dev/RIOT/tests/sys/vfs_default/bin/nrf52840dk/tests_vfs_default.elf
J-Link connection not established yet but required for command.
Connecting to J-Link via USB...O.K.
Firmware: J-Link OB-SAM3U128-V2-NordicSemi compiled Jan 20 2022 16:43:31
Hardware version: V1.00
S/N: 683332925
License(s): RDI, FlashBP, FlashDL, JFlash, GDB
USB speed mode: High speed (480 MBit/s)
VTref=3.300V
Target connection not established yet but required for command.
Device "NRF52" selected.


Connecting to target via SWD
InitTarget() start
InitTarget() end
Found SW-DP with ID 0x2BA01477
DPIDR: 0x2BA01477
CoreSight SoC-400 or earlier
Scanning AP map to find all available APs
AP[2]: Stopped AP scan as end of AP map has been reached
AP[0]: AHB-AP (IDR: 0x24770011)
AP[1]: JTAG-AP (IDR: 0x02880000)
Iterating through AP map to find AHB-AP to use
AP[0]: Core found
AP[0]: AHB-AP ROM base: 0xE00FF000
CPUID register: 0x410FC241. Implementer code: 0x41 (ARM)
Found Cortex-M4 r0p1, Little endian.
FPUnit: 6 code (BP) slots and 2 literal slots
CoreSight components:
ROMTbl[0] @ E00FF000
[0][0]: E000E000 CID B105E00D PID 000BB00C SCS-M7
[0][1]: E0001000 CID B105E00D PID 003BB002 DWT
[0][2]: E0002000 CID B105E00D PID 002BB003 FPB
[0][3]: E0000000 CID B105E00D PID 003BB001 ITM
[0][4]: E0040000 CID B105900D PID 000BB9A1 TPIU
[0][5]: E0041000 CID B105900D PID 000BB925 ETM
Cortex-M4 identified.
Downloading file [/home/benpicco/dev/RIOT/tests/sys/vfs_default/bin/nrf52840dk/tests_vfs_default.elf]...
File is of unknown / supported format.

Script processing completed.

[benpicco]

Hm nvm, updating JLinkExe to 7.8811 also fixed this.