boards: add support for Adafruit Feather nRF52840 Sense #20027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelRottleuthner
requested review from
jia200x and
MrKevinWeiss
as code owners
github-actions
bot
added
Area: doc
benpicco
reviewed
Oct 27, 2023
benpicco
added
the
CI: ready for build
benpicco
reviewed
Oct 27, 2023
MichelRottleuthner
force-pushed
the
pr_feather-nrf52840-sense
branch
from
be64240 to
f27f96a
Compare
MichelRottleuthner
force-pushed
the
pr_feather-nrf52840-sense
branch
from
f27f96a to
7842b70
Compare
|
Amended missing kconfig sensor declarations to fix make/kconfig module mismatch. |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Thanks for the swift review @benpicco |
bors bot
added a commit
that referenced
this pull request
Nov 2, 2023
20035: Bump version of UF2 package r=MrKevinWeiss a=MichelRottleuthner ### Contribution description Bump UF2 package version. The new version, besides many other things, also includes an improvement to search more potential mount paths, which gives better compatibility for different distros. ### Testing procedure Test if flashing still works for boards that use UF2 (e.g., `feather-nrf52840`, `feather-nrf52840-sense`, `nrf52840-mdk-dongle`): `BUILD_IN_DOCKER=1 BOARD=feather-nrf52840-sense make -C examples/hello-world all flash term` With master you should get this error, during flashing: `No drive to deploy.` if you run it on a distro that mounts your device under something like `/run/media/<username>/FTHRSNSBOOT`, or other paths not supported by the old version. To me this happened on Arch. **Note: you will still get this error if your system doesn't auto mount the device.** But now it will be found when mounted ;) With this PR try again with the UF2 util: `rm -rf build/pkg/UF2` `BUILD_IN_DOCKER=1 BOARD=feather-nrf52840-sense make -C examples/hello-world all flash term` It should use the new pkg version and flash successfully: ``` ... [INFO] uf2conv.py not found - fetching it from GitHub now CC= CFLAGS= make -C /home/michel/devel/riot/dist/tools/uf2 [INFO] uf2conv.py successfully fetched! ... Flashing /run/media/michel/FTHRSNSBOOT (nRF52840-Feather-Sense) Wrote 63488 bytes to /run/media/michel/FTHRSNSBOOT/NEW.UF2 ... ``` ### Issues/PRs references Fixes the mount path problem described in #20027. Co-authored-by: Michel Rottleuthner <michel.rottleuthner@haw-hamburg.de>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds support for the Adafruit Feather nRF52840 Sense. A nice prototyping board that comes with many onboard sensors. RIOT already supports most of it.
Note: you may need to update the bootloader in order to make flashing work. Version 0.7 worked fine for me. Note that some OSes do not auto mount the UF2 drive which prevents flashing. The uf2 helper
dist/tools/uf2/uf2conv.pycould use some improvements for handling distro-specific mount paths properly, which also applies to existing boards.Unsupported features
Making use of the LSM6DS33 gyro/accelerometer might need some work on an existing driver (#17053). Currently there is no support for the PDM peripheral used by the digital MEMS microphone. The NeoPixel LED lacks an nrf52-specific integration for the
ws281xdriver. All of that can be done in follow ups.Testing procedure
Flash and run some apps e.g.,
examples/gnrc_networkingandexamples/sauland check that both work as intended.In the saul app
> saul read allshould give you a bunch of correct readings for the sensors. Both worked fine for me.Issues/PRs references
None.