Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cpu/cc2538: fix EUI provider #20228

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jan 4, 2024

Contribution description

The cc2538_get_eui64_primary function was not used because cc2538_eui_primary.h gets included by board.h but board.h is not included by eui64_provider_params.h.

Testing procedure

Connecting to target...
CC2538 PG2.0: 512KB Flash, 32KB SRAM, CCFG at 0x0027FFD4
Primary IEEE Address: 00:12:4B:00:18:F1:D6:5E
    Erase before write done                 
Writing 524288 bytes starting at address 0x00200000
Write 16 bytes at 0x0027FFF0F8
    Write done                              
/home/benpicco/dev/RIOT/dist/tools/pyterm/pyterm -p "/dev/ttyUSB1" -b "115200"  
2024-01-04 13:15:16,895 # Connect to serial port /dev/ttyUSB1
Welcome to pyterm!
Type '/exit' to exit.
ifconfig
2024-01-04 13:15:29,967 # > ifconfig
2024-01-04 13:15:29,983 # Iface  6  HWaddr: 56:5E  Channel: 26  NID: 0x23  PHY: O-QPSK 
2024-01-04 13:15:29,983 #           Long HWaddr: 00:12:4B:00:18:F1:D6:5E 
2024-01-04 13:15:29,984 #            State: IDLE 
2024-01-04 13:15:29,984 #           ACK_REQ  L2-PDU:102  MTU:1280  HL:64  RTR  
2024-01-04 13:15:29,999 #           RTR_ADV  6LO  IPHC  
2024-01-04 13:15:29,999 #           Source address length: 8
2024-01-04 13:15:30,000 #           Link type: wireless
2024-01-04 13:15:30,000 #           inet6 addr: fe80::212:4b00:18f1:d65e  scope: link  VAL
2024-01-04 13:15:30,014 #           inet6 group: ff02::2
2024-01-04 13:15:30,015 #           inet6 group: ff02::1
2024-01-04 13:15:30,015 #           inet6 group: ff02::1:fff1:d65e
2024-01-04 13:15:30,016 #           inet6 group: ff02::1a

Issues/PRs references

@benpicco benpicco requested a review from maribu January 4, 2024 12:18
@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: network Area: Networking Area: cpu Area: CPU/MCU ports Area: sys Area: System labels Jan 4, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 4, 2024
@maribu
Copy link
Member

maribu commented Jan 4, 2024

Connecting to target...
CC2538 PG2.0: 512KB Flash, 32KB SRAM, CCFG at 0x0027FFD4
Primary IEEE Address: 00:12:4B:00:19:40:BB:27
    Erase before write done                 
Writing 524288 bytes starting at address 0x00200000
Write 16 bytes at 0x0027FFF0F8
    Write done                              
/home/maribu/Repos/software/RIOT/master/dist/tools/pyterm/pyterm -p "/dev/ttyUSB0" -b "115200"  
2024-01-04 13:21:41,019 # Connect to serial port /dev/ttyUSB0
Welcome to pyterm!
Type '/exit' to exit.
ifconfig
2024-01-04 13:21:50,427 # ifconfig
2024-01-04 13:21:50,433 # Iface  3  HWaddr: 3B:27  Channel: 26  NID: 0x23  PHY: O-QPSK 
2024-01-04 13:21:50,438 #           Long HWaddr: 00:12:4B:00:19:40:BB:27 
2024-01-04 13:21:50,440 #            State: IDLE 
2024-01-04 13:21:50,446 #           ACK_REQ  L2-PDU:102  Source address length: 2
2024-01-04 13:21:50,449 #           Link type: wireless
2024-01-04 13:21:50,450 #  

Works as promised! Thanks :-)

@maribu maribu enabled auto-merge January 4, 2024 12:22
@benpicco benpicco added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Jan 4, 2024
@riot-ci
Copy link

riot-ci commented Jan 4, 2024

Murdock results

✔️ PASSED

ecb1e57 net/eui_provider: include board.h

Success Failures Total Runtime
8101 0 8101 11m:53s

Artifacts

@maribu maribu added this pull request to the merge queue Jan 4, 2024
Merged via the queue into RIOT-OS:master with commit 616b48d Jan 4, 2024
27 checks passed
@benpicco benpicco deleted the cc2538_get_eui64_primary branch January 4, 2024 17:32
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: cpu Area: CPU/MCU ports Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants