print: Missing size_t print format specifiers #20249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: network
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Jan 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
benpicco
reviewed
Jan 12, 2024
| @@ -645,7 +645,7 @@ static int _atwinc15x0_get(netdev_t *netdev, netopt_t opt, void *val, | |||
| assert(dev); | |||
| assert(dev == atwinc15x0); | |||
|
|
|||
| DEBUG("%s dev=%p opt=%u val=%p max_len=%u\n", __func__, | |||
| DEBUG("%s dev=%p opt=%u val=%p max_len=%" PRIuSIZE "\n", __func__, | |||
There was a problem hiding this comment.
looks like those macros are not known here?
There was a problem hiding this comment.
It's missing #include "architecture.h".
The header is included in many places, so it tried to get away with not including it in every file that uses PRIuSIZE. I am currently building all examples/tests with the board to see if there are other problems with this board.
If it's ok, I'll add the missing includes and force push a version with the missing includes.
There was a problem hiding this comment.
All builds for lora-e5-dev should work. I also tried some other platforms, but didn't find any other problems.
fzi-haxel
force-pushed
the
pr/size_t_format_fixes
branch
from
312ed02 to
291c89f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
I seem to have missed some
size_tprints without casts indriversandtests/unittests/tests-uri_parser/tests-uri_parser.c.I also made two mistakes in
sys/net/gnrc.This PR fixes them.
Testing procedure
This should have no functional impact on currently supported architectures, as
sizeof(size_t) == sizeof(unsigned)is true for all them. Test as usual.Issues/PRs references
Fixes #20194