Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tests: don't explicitly set RIOT_TERMINAL=native #20277

Merged
merged 1 commit into from
Jan 19, 2024
Merged

tests: don't explicitly set RIOT_TERMINAL=native #20277

merged 1 commit into from
Jan 19, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

RIOT_TERMINAL=pyterm is now only used with the term target, the native term is the default for everything else, including tests. So we don't have to set it for every test.

Testing procedure

CI should do the job

Issues/PRs references

follow-up to #20264

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Jan 19, 2024
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jan 19, 2024
@benpicco benpicco requested a review from OlegHahm January 19, 2024 17:14
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 19, 2024
@riot-ci
Copy link

riot-ci commented Jan 19, 2024

Murdock results

✔️ PASSED

f9d5328 tests: don't explicitly set RIOT_TERMINAL=native

Success Failures Total Runtime
130 0 131 02m:13s

Artifacts

@benpicco benpicco added this pull request to the merge queue Jan 19, 2024
Merged via the queue into RIOT-OS:master with commit d9da212 Jan 19, 2024
29 checks passed
@benpicco benpicco deleted the tests/RIOT_TERMINAL branch January 19, 2024 20:59
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@OlegHahm OlegHahm Awaiting requested review from OlegHahm

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @maribu @MrKevinWeiss