Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

boards/weact-g030f6: add support for minimal break-out board #20337

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 4, 2024

Contribution description

This adds support for a cheap little board based on STM32G030F6.

Weact-stm32g030f6p6

It is pretty straightforward, except that there is no RTT. This uncovered a bug in stm32g0316-disco which I based this on where the board would not set TIMER_0_MAX_VALUE for the 16 bit timer, leading to way too early timeouts with ztimer_msec.

Since it's just a single line, I added the fix to this PR.

I also noticed that periph_rtc was not supported for this CPU family yet, so I added the required definitions.

I also noticed that I sometimes have trouble flashing the device with a DAP-Link Programmer with

Error: Error connecting DP: cannot read IDR

I then have to hold the reset button and release it once OpenOCD starts probing the CPU - I have NRST connected, so maybe my debugger is just not using it.

Testing procedure

RTC works with alarm:

2024-02-04 19:57:36,308 # > rtc gettime
2024-02-04 19:57:36,308 # 
2024-02-04 19:57:36,309 # 2024-02-04 19:57:33

2024-02-04 19:57:52,373 # > rtc setalarm 2024-02-04 19:58:00
2024-02-04 19:57:52,373 # 
2024-02-04 19:58:03,438 # > The alarm rang

I am a bit wondering if the alarm is working on STM32G4 as I would expect that it should select the same code path as STM32G0 (and STM32L5).
With the default the alarm would not get cleared and keep triggering.

Issues/PRs references

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: doc Area: Documentation Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels Feb 4, 2024
@benpicco benpicco requested a review from maribu February 4, 2024 19:00
@maribu maribu enabled auto-merge February 4, 2024 19:25
@benpicco benpicco force-pushed the boards/weact-g030f6 branch from 199e80a to b254ab6 Compare February 4, 2024 21:22
@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: examples Area: Example Applications labels Feb 4, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 4, 2024
@riot-ci
Copy link

riot-ci commented Feb 4, 2024

Murdock results

✔️ PASSED

e207848 boards/stm32g0316-disco: enable periph_rtc

Success Failures Total Runtime
8627 0 8627 09m:56s

Artifacts

@maribu maribu added this pull request to the merge queue Feb 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2024
@benpicco benpicco force-pushed the boards/weact-g030f6 branch from b254ab6 to e207848 Compare February 4, 2024 23:45
@benpicco benpicco enabled auto-merge February 4, 2024 23:47
@benpicco benpicco added this pull request to the merge queue Feb 5, 2024
Merged via the queue into RIOT-OS:master with commit 0eddf4a Feb 5, 2024
25 checks passed
@benpicco benpicco deleted the boards/weact-g030f6 branch February 5, 2024 11:10
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: examples Area: Example Applications Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants