Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

boards/nucleo-f722ze: doc update #20671

Merged
merged 1 commit into from
May 15, 2024
Merged

boards/nucleo-f722ze: doc update #20671

merged 1 commit into from
May 15, 2024

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

This PR adds some improvements to the board documentation page for Nucleo-f722ze:

Testing procedure

Generate documentation and see if everything is OK.

make doc
xdg-open doc/doxygen/html/group__boards__nucleo-f722ze.html

Issues/PRs references

PR #17453

@krzysztof-cabaj krzysztof-cabaj requested a review from aabadie as a code owner May 15, 2024 06:53
@github-actions github-actions bot added Area: doc Area: Documentation Area: boards Area: Board ports labels May 15, 2024
dylad
dylad reviewed May 15, 2024
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

boards/nucleo-f722ze/doc.txt Outdated
| Timers | 18 (2x watchdog, 1 SysTick, 2x 32-bit, 13x 16-bit) |
| ADCs | 3x 12 bit (up to 24 channels) |
| UARTs | 4 |
| I2cs | 3 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking. You may squash directly.

Suggested change
| I2cs | 3 |
| I2Cs | 3 |

@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels May 15, 2024
@riot-ci
Copy link

riot-ci commented May 15, 2024 •
edited
Loading

Murdock results

✔️ PASSED

d6d22dd boards/nucleo-f722ze: doc update

Success Failures Total Runtime
1 0 1 01m:06s

Artifacts

@krzysztof-cabaj
Copy link
Contributor Author

@dylad Thanks!

Fixed. Squashed. CI green.

dylad
dylad approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@dylad dylad enabled auto-merge May 15, 2024 08:03
@dylad dylad added this pull request to the merge queue May 15, 2024
Merged via the queue into RIOT-OS:master with commit f2b0561 May 15, 2024
26 checks passed
@krzysztof-cabaj krzysztof-cabaj mentioned this pull request May 24, 2024
Merged
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dylad dylad dylad approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krzysztof-cabaj @riot-ci @dylad @mguetschow