dist/tools/tapsetup: make compatible with doas #20712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`doas` doesn't set `SUDO_USER`, but `DOAS_USER`. This populates `SUDO_USER` with `DOAS_USER` if it is empty, so the script works with both doas and sudo.
maribu
added
Type: enhancement
benpicco
approved these changes
May 30, 2024
benpicco
added
the
CI: skip compile test
|
Thx for the quick review :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
doasdoesn't setSUDO_USER, butDOAS_USER. This populatesSUDO_USERwithDOAS_USERif it is empty, so the script works with both doas and sudo.Testing procedure
sudo dist/tools/tapsetup/tapsetupshould still work on systems wheresudois not thedoas-sudo-shimbut in fact the real legacy sudo tool.Issues/PRs references
None