Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

boards/weact-g030f6: fix use with stdio_rtt #20806

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Aug 4, 2024

Contribution description

Running

USEMODULE=stdio_rtt make BOARD=weact-g030f6 -C ... flash term

failed due the programmer not being specified by the time the serial is configured:

makefiles/tools/serial.inc.mk:44: "Warning: No RIOT_TERMINAL set,
but using stdio_rtt: The default terminal is likely not to work."

This reorders the setup of the board to first configure the programmer and then the serial, so that using stdio_rtt now works out of the box.

Testing procedure

USEMODULE=stdio_rtt make BOARD=weact-g030f6 -C examples/default flash term

should now work

Issues/PRs references

None

Running

    USEMODULE=stdio_rtt make BOARD=weact-g030f6 -C ... flash term

failed due the programmer not being specified by the time the serial
is configured:

    makefiles/tools/serial.inc.mk:44: "Warning: No RIOT_TERMINAL set,
    but using stdio_rtt: The default terminal is likely not to work."

This reorders the setup of the board to first configure the programmer
and then the serial, so that using stdio_rtt now works out of the box.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Aug 4, 2024
@maribu maribu requested a review from benpicco August 4, 2024 08:32
@riot-ci
Copy link

riot-ci commented Aug 4, 2024

Murdock results

✔️ PASSED

5a02899 boards/weact-g030f6: fix use with stdio_rtt

Success Failures Total Runtime
405 0 405 06m:07s

Artifacts

@benpicco benpicco enabled auto-merge August 5, 2024 10:58
@benpicco benpicco added this pull request to the merge queue Aug 5, 2024
@maribu maribu removed this pull request from the merge queue due to a manual request Aug 5, 2024
@maribu maribu added this pull request to the merge queue Aug 5, 2024
Merged via the queue into RIOT-OS:master with commit c8b6514 Aug 5, 2024
30 checks passed
@maribu maribu deleted the boards/weact-g030f6 branch October 10, 2024 08:25
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants