Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cpu/esp32: Improve error descriptions #20914

Merged
merged 2 commits into from
Oct 16, 2024
Merged

cpu/esp32: Improve error descriptions #20914

merged 2 commits into from
Oct 16, 2024

Conversation

AnnsAnns
Copy link
Contributor

@AnnsAnns AnnsAnns commented Oct 16, 2024 •
edited
Loading

Contribution description

This PR improves the error messages of the esp32 common makefiles when adding new esp32 based boards/cpu.

The previous error messages did not make it clear which part was still missing when adding a new esp32 based board/cpu variant, thus making it needlessly complicated to pinpoint the problem (and also had a minor spelling mistake).

This also fixes the same spelling mistake for the cortexm error message.

Testing procedure

I tested the hello_world on both nativeand esp32c3-devkit and also while adding a new variant to the esp32 family. In all three cases everything worked as expected and it helped me to locate issues while adding a new variant.

Issues/PRs references

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Oct 16, 2024
gschorcht
gschorcht approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks for improving the make system for ESP32x SoCs 😄

@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 16, 2024
@benpicco benpicco enabled auto-merge October 16, 2024 14:42
@riot-ci
Copy link

riot-ci commented Oct 16, 2024

Murdock results

✔️ PASSED

db2a20c cpu/cortexm: fix spelling mistake

Success Failures Total Runtime
10215 0 10215 19m:49s

Artifacts

@benpicco benpicco added this pull request to the merge queue Oct 16, 2024
Merged via the queue into RIOT-OS:master with commit 31036eb Oct 16, 2024
28 checks passed
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnnsAnns @riot-ci @gschorcht @benpicco