Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests/build_system/xfa: improve test coverage #20959

Merged
1 commit merged into from
Nov 7, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 6, 2024

Contribution description

This increases the test coverage for XFA:

  • Multiple entries are added from a single file
  • Priorities are assigned to enforce a given order
  • The size of the struct to add is changed to no longer be a power of 2

Testing procedure

The test is automated and should pass in the CI. It will fail on native64, though.

Issues/PRs references

None

This increases the test coverage for XFA:

- Multiple entries are added from a single file
- Priorities are assigned to enforce a given order
- The size of the `struct` to add is changed to no longer be a power of
  2
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Nov 6, 2024
@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 6, 2024
@riot-ci
Copy link

riot-ci commented Nov 6, 2024

Murdock results

FAILED

2839224 tests/build_system/xfa: improve test coverage

Success Failures Total Runtime
14 0 20 16s

Artifacts

@maribu
Copy link
Member Author

maribu commented Nov 6, 2024

#20960 would fix the bug this tests shows. Sadly, it changes the API of the XFA() and XFA_CONST() macros.

Luckily, those macros are so inconvenient to use that almost all users added a convenience wrapper on top of XFA(), so that I could update the wrappers rather than every user of the wrappers.

@github-merge-queue github-merge-queue bot closed this pull request by merging all changes into RIOT-OS:master in d65dec6 Nov 7, 2024
@maribu maribu deleted the tests/build_system/xfa branch November 7, 2024 19:47
@maribu
Copy link
Member Author

maribu commented Nov 7, 2024

Merged via #20960

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants