Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests/net/nanocoap_cli: make use of XFA for shell commands #20961

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 6, 2024

Contribution description

As the title says: This changes the test to make use of the SHELL_COMMAND() macro.

Testing procedure

Everything should work as before, except for the order of the commands in help.

This sadly increases the size of .text a bit. Something that #20958 would fix.

Issues/PRs references

None

@maribu maribu added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 6, 2024
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Nov 6, 2024
@maribu maribu force-pushed the tests/net/nanocoap_cli/modernize branch from 9c7481d to e436f45 Compare November 6, 2024 20:36
@riot-ci
Copy link

riot-ci commented Nov 6, 2024

Murdock results

✔️ PASSED

e436f45 tests/net/nanocoap_cli: make use of XFA for shell commands

Success Failures Total Runtime
19 0 19 01m:47s

Artifacts

Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Teufelchen1 Teufelchen1 added this pull request to the merge queue Nov 25, 2024
Merged via the queue into RIOT-OS:master with commit 1ac0c2c Nov 26, 2024
26 checks passed
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants