.clang-format: Set ColumnLimit to 0 #20963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables adding/removing line breaks by `clang-format`, as this could very well introduce regressions in code formatting in terms of our coding convention: If a long array was matching the soft limit of 80 chars per line, `clang-format` would reflow it to match the hard limit of 100 chars. One can selectively disable `clang-format` with magic comments. But at this point, I'd say we should rather disable this feature until we can configure it in a way to match our coding convention better (without having to add magic comments).
maribu
added
Type: enhancement
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This disables adding/removing line breaks by
clang-format, as this could very well introduce regressions in code formatting in terms of our coding convention: If a long array was matching the soft limit of 80 chars per line,clang-formatwould reflow it to match the hard limit of 100 chars.One can selectively disable
clang-formatwith magic comments. But at this point, I'd say we should rather disable this feature until we can configure it in a way to match our coding convention better (without having to add magic comments).Testing procedure
With this PR,
clang-formatshould not increase the column with above 80 chars anymore.Issues/PRs references
None