-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
cpu/sam4s: add initial support with SAM4S-XPRO board #21201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the hardware to test this, but just two things I noticed while glancing over this.
static-tests are happy ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, feel free to squash!
Signed-off-by: dylad <dylan.laduranty@mesotic.com>
Signed-off-by: dylad <dylan.laduranty@mesotic.com>
ba6bc9a
to
9e920b2
Compare
I've addressed @benpicco's comments and squashed. |
Ah Murdock catches something. |
This commit allows to share GPIO, Timers and UARTs driver across SAM3/SAM4s MCUs as they relies on the same IPs Signed-off-by: dylad <dylan.laduranty@mesotic.com>
Signed-off-by: dylad <dylan.laduranty@mesotic.com>
9e920b2
to
363fb75
Compare
Contribution description
This PR adds initial support for SAM4s MCUs from Microchip (formerly Atmel) and its sam4s-xpro board.
There are a bit old already, but still produced by Microchip and their headers files are already in-tree.
This family is pretty close to SAM3 (which we already support through
arduino-due
) except that this is a Cortex-M4 which runs a little faster.Since peripherals are the same, I've moved GPIOs, Timer and UART driver to
cpu/sam_common
.I plan to move the remaining drivers (if relevant) in followup PRs.
Testing procedure
Get a
sam4s-xpro
and run any tests involving UART/Timers/GPIOs.For the record here is the output of tests/sys/shell running on sam4s-xpro:
Issues/PRs references
None.