Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cpu/samd21: Add samd21 pwm driver #2473

Closed
wants to merge 4 commits into from
Closed

cpu/samd21: Add samd21 pwm driver #2473

wants to merge 4 commits into from

Conversation

PeterKietzmann
Copy link
Member

This is an implementation of a pwm lowlevel driver for samr21-xpro boards. Please note that the pwm_mode_t mode is not yet implemented for this board.

@PeterKietzmann PeterKietzmann added the Area: drivers Area: Device drivers label Feb 19, 2015
thomaseichinger
thomaseichinger reviewed Feb 20, 2015
View reviewed changes
cpu/samd21/periph/pwm.c
/* ignore file in case no PWM devices are defined */
#if PWM_NUMOF

int round_to_prescaler(unsigned int frequency, unsigned int resolution, int *presc);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be static, right?

@PeterKietzmann
Copy link
Member Author

addressed latest comments

PeterKietzmann
PeterKietzmann reviewed Feb 20, 2015
View reviewed changes
boards/samr21-xpro/include/periph_conf.h
#define PWM_1_PM PM_APBCMASK_TCC1
/* PWM 1 pin configuration */
#define PWM_1_PORT (PORT->Group[0])
#define PWM_1_PIN_CH0 (6)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be aware that this pin is used for ADC_0 in PR #2063

@thomaseichinger
Copy link
Member

@PeterKietzmann needs rebase.

@PeterKietzmann
Copy link
Member Author

I rebased and squashed. We should not forget that the pwm_mode_t mode is still not handled

@thomaseichinger thomaseichinger mentioned this pull request Mar 4, 2015
Closed
21 tasks
@PeterKietzmann
Copy link
Member Author

@thomaseichinger I tried to implement the left and right aligned pwm modes for the samr21-xpro. According to the reference manual (section 28.6.2.5 page 617) I wanted to use the up-counting mode for the left-aligned pwm and the down-counting mode for the right-aligned pwm. The corresponding register-content (PWM_0_DEV->CTRLBCLR.reg or PWM_0_DEV->CTRLBSET.reg) seems to be correct in both cases. However, running the REMOVE_ME_pwm_test with a connected logic analyzer shows nearly no difference between the modes. Any ideas?

@PeterKietzmann
Copy link
Member Author

In addition: Do you know a way to measure the regarding clock signal?

@OlegHahm OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@haukepetersen haukepetersen mentioned this pull request May 30, 2015
Merged
@haukepetersen
Copy link
Contributor

@PeterKietzmann: I just opened a new PR with a slightly adapted version of your PWM driver: #3127. Should we close this then?

@PeterKietzmann
Copy link
Member Author

Yes of course! Will test the new one soon

@PeterKietzmann PeterKietzmann deleted the add_samd21_pwm branch June 5, 2015 12:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@thomaseichinger thomaseichinger

Labels
Area: drivers Area: Device drivers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterKietzmann @thomaseichinger @haukepetersen