ng_sixlowpan: initial import #2614

miri64 · 2015-03-16T16:56:38Z

~~Depends on #2433 and all its dependencies.~~ (merged)

This only implements handling and sending of uncompressed, unfragmented IPv6 packets. The rest will come as a follow-up:

fragmentation ng_sixlowpan: Initial import of datagram fragmentation #2781
IPHC ng_sixlowpan: Initial import of IP header compression #2806

miri64 · 2015-03-19T15:00:58Z

Rebased to current #2555

miri64 · 2015-03-25T02:00:34Z

Rebased to current #2555

miri64 · 2015-03-30T01:00:59Z

Rebased to current #2555

miri64 · 2015-04-01T16:07:53Z

Rebased to current #2555

miri64 · 2015-04-07T13:40:10Z

Rebased to current #2555

miri64 · 2015-04-08T10:26:08Z

Rebased to current #2555

OlegHahm · 2015-04-23T07:29:53Z

Makefile.dep

+ifneq (,$(filter ng_sixlowpan,$(USEMODULE)))
+  USEMODULE += ng_sixlowpan_netif
+  USEMODULE += ng_netbase
+endif


Conceptional: Shouldn't be IPv6 also a dependency?

Conceptionally, yes. To work: no. If we ever want to introduce stand-alone tests for every layer we would not need IPv6 here.

OlegHahm · 2015-04-23T07:40:23Z

Sorry for my somewhat nit-picky style comments. I just note down whatever I find, but it's up to you if you want to address it directly or postpone it to a later PR. Just let me know.

OlegHahm · 2015-04-23T07:43:31Z

sys/net/network_layer/ng_ipv6/ng_ipv6.c

+
+    ((ng_netif_hdr_t *)pkt->data)->if_pid = iface;
+
+    if ((if_entry != NULL) && (if_entry->flags & NG_IPV6_NETIF_FLAGS_SIXLOWPAN)) {


Can we not exit early if if_entry is NULL?

There is no exit on if_entry == NULL, it is just send to iface (which is assumed to be a valid PID at this point).

I thought NULL indicates that the PID is probably not valid.

Can you still explain this? What does NULL as a return value for ng_ipv6_netif_get(iface); indicate here?

That there is no IPv6 interface. This is not a case that should happen here so maybe we can even remove the NULL test

miri64 · 2015-04-23T09:25:54Z

Addressed comments.

OlegHahm · 2015-04-23T09:28:44Z

Everything's addressed. The rest looks good. ACK. Please squash.

miri64 · 2015-04-23T09:31:02Z

Done.

miri64 · 2015-04-23T14:17:40Z

Can't restart the failed job. So merge.

ng_sixlowpan: initial import

BytesGalore · 2015-04-23T16:41:21Z

sys/net/network_layer/ng_sixlowpan/ng_sixlowpan.c

+    ng_sixlowpan_netif_t *iface;
+    /* cppcheck: datagram_size will be read by frag */
+    /* cppcheck-suppress unreadVariable */
+    size_t payload_len, datagram_size;


~~The suppression doesn't seem to work for me I got -Wunused-but-set-variable warning for datagram_size here, anyone else?~~

gcc: gcc version 4.9.3 20141119 (release) [ARM/embedded-4_9-branch revision 218278] (GNU Tools for ARM Embedded Processors)

It's a suppression for cppchech, not for gcc.

ahh, my bad thx

The correct way to suppress the GCC warning is to cast to void, at least for function arguments, I guess it should work for local variables as well.

(void) datagram_size;

edit: However, I do not understand what the purpose of the variable is when it is only set and never used, even as by reference.

@gebart I know that. The variable is supposed to be used in #2781 and I did not introduce Toi many lines I would revert there anyways.

miri64 added Area: network Area: Networking Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: waiting for other PR State: The PR requires another PR to be merged first NSTF labels Mar 16, 2015

miri64 added this to the Network Stack Task Force milestone Mar 16, 2015

miri64 assigned OlegHahm Mar 16, 2015

miri64 mentioned this pull request Mar 16, 2015

Network stack refactoring: TODO list #2278

Closed

36 tasks

miri64 force-pushed the ng_sixlowpan/feat/initial branch 2 times, most recently from 6ce4e84 to dc7214c Compare March 19, 2015 15:00

miri64 mentioned this pull request Mar 23, 2015

sixlowpan: Clean-up, take IPv6 out, and refactor to netapi #1680

Closed

miri64 force-pushed the ng_sixlowpan/feat/initial branch from dc7214c to 7fd337b Compare March 25, 2015 02:00

miri64 force-pushed the ng_sixlowpan/feat/initial branch from 7fd337b to 33f0a83 Compare March 30, 2015 01:00

Lotterleben force-pushed the master branch from 1d9f189 to d4e068b Compare March 31, 2015 09:52

OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01

miri64 force-pushed the ng_sixlowpan/feat/initial branch from 33f0a83 to e4f8f30 Compare April 1, 2015 16:07

miri64 force-pushed the ng_sixlowpan/feat/initial branch from e4f8f30 to dd4e87f Compare April 7, 2015 13:39

miri64 force-pushed the ng_sixlowpan/feat/initial branch from dd4e87f to 77395f0 Compare April 7, 2015 17:55

miri64 mentioned this pull request Apr 7, 2015

ipv6_netif: expand interface #2735

Merged

miri64 force-pushed the ng_sixlowpan/feat/initial branch from 77395f0 to 2a3ad06 Compare April 8, 2015 10:25

miri64 force-pushed the ng_sixlowpan/feat/initial branch from 2841b18 to 127d741 Compare April 9, 2015 16:16

miri64 mentioned this pull request Apr 9, 2015

shell: add support for (un-)setting 6LoWPAN support on an interface #2780

Merged

miri64 force-pushed the ng_sixlowpan/feat/initial branch from a2c0e06 to ce1e94b Compare April 10, 2015 05:59

miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Apr 22, 2015

OlegHahm reviewed Apr 23, 2015
View reviewed changes

OlegHahm mentioned this pull request Apr 23, 2015

wiki: add a page with best programming practices #2861

Closed

OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 23, 2015

miri64 and others added 2 commits April 23, 2015 11:29

ng_sixlowpan_netif: initial import

07e2dba

ng_sixlowpan: initial import

5412e0e

miri64 force-pushed the ng_sixlowpan/feat/initial branch from d4cc6e9 to 5412e0e Compare April 23, 2015 09:30

miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 23, 2015

miri64 added a commit that referenced this pull request Apr 23, 2015

Merge pull request #2614 from authmillenon/ng_sixlowpan/feat/initial

1d74465

ng_sixlowpan: initial import

miri64 merged commit 1d74465 into RIOT-OS:master Apr 23, 2015

miri64 deleted the ng_sixlowpan/feat/initial branch April 23, 2015 14:17

BytesGalore reviewed Apr 23, 2015
View reviewed changes

miri64 mentioned this pull request Apr 25, 2015

drivers: new driver for at86rf2xx radios #2825

Merged

miri64 mentioned this pull request May 12, 2015

[WIP] ng_ndp: Initial import of router discovery #2612

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ng_sixlowpan: initial import #2614

ng_sixlowpan: initial import #2614

miri64 commented Mar 16, 2015

miri64 commented Mar 19, 2015

miri64 commented Mar 25, 2015

miri64 commented Mar 30, 2015

miri64 commented Apr 1, 2015

miri64 commented Apr 7, 2015

miri64 commented Apr 8, 2015

OlegHahm Apr 23, 2015

miri64 Apr 23, 2015

OlegHahm commented Apr 23, 2015

OlegHahm Apr 23, 2015

miri64 Apr 23, 2015

OlegHahm Apr 23, 2015

OlegHahm Apr 23, 2015

miri64 Apr 23, 2015

miri64 commented Apr 23, 2015

OlegHahm commented Apr 23, 2015

miri64 commented Apr 23, 2015

miri64 commented Apr 23, 2015

BytesGalore Apr 23, 2015

OlegHahm Apr 23, 2015

BytesGalore Apr 23, 2015

jnohlgard Apr 23, 2015

miri64 Apr 23, 2015


		((ng_netif_hdr_t *)pkt->data)->if_pid = iface;

		if ((if_entry != NULL) && (if_entry->flags & NG_IPV6_NETIF_FLAGS_SIXLOWPAN)) {

ng_sixlowpan: initial import #2614

ng_sixlowpan: initial import #2614

Conversation

miri64 commented Mar 16, 2015

miri64 commented Mar 19, 2015

miri64 commented Mar 25, 2015

miri64 commented Mar 30, 2015

miri64 commented Apr 1, 2015

miri64 commented Apr 7, 2015

miri64 commented Apr 8, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OlegHahm commented Apr 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miri64 commented Apr 23, 2015

OlegHahm commented Apr 23, 2015

miri64 commented Apr 23, 2015

miri64 commented Apr 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment