sys: net: add netdev device driver using dev_eth low-level ethernet driver API #2776

kaspar030 · 2015-04-09T16:56:44Z

Based on #2558. Depends on #2766. Obsoletes #2770.

This PR makes any ethernet device that implements #2766 available for the new network stack.

kaspar030 · 2015-04-09T16:59:07Z

(the test will not print any packets if pktdump's priority is not raised. see #2774)

kaspar030 · 2015-04-12T07:38:59Z

fixed travis unhappyness, rebased

jonas-rem · 2015-04-13T08:53:34Z

Hm, I am not sure if I can help here a lot. Have some trouble testing this.

I checked out the ng_icmpv6/feat/initial branch (Like Martine described in the mailing-list)
pulled ng_tapnet: initial import of a pure Ethernet device for native #2558 (ng_tapnet)
pulled this one (sys: net: add netdev device driver using dev_eth low-level ethernet driver API #2776). Got some merge in this step
set up tapnet using: cpu/native/tapsetup.sh create 2
Building Riot was sucessful
When starting Riot using: PORT=tap1 make term I got an error:

  51614     456   85920  137990   21b06 /home/jonas/git_repos/RIOT_MLENDERS/RIOT/tests/driver_netdev_eth/bin/native/driver_netdev_eth.elf
/home/jonas/git_repos/RIOT_MLENDERS/RIOT/tests/driver_netdev_eth/bin/native/driver_netdev_eth.elf tap0 
usage: /home/jonas/git_repos/RIOT_MLENDERS/RIOT/tests/driver_netdev_eth/bin/native/driver_netdev_eth.elf [-i <id>] [-d] [-e|-E] [-o]
 help: /home/jonas/git_repos/RIOT_MLENDERS/RIOT/tests/driver_netdev_eth/bin/native/driver_netdev_eth.elf -h

Options:
-h          help
-i <id>     specify instance id (set by config module)
-s <seed>   specify srandom(3) seed (/dev/random is used instead of
            random(3) if the option is omitted)
-d          daemonize
-e          redirect stderr to file
-E          do not redirect stderr (i.e. leave sterr unchanged despite
            daemon/socket io)
-o          redirect stdout to file (/tmp/riot.stdout.PID) when not attached
            to socket

The order of command line arguments matters.
make: *** [term] Error 1

Is this setup generally correct, what is missing there?

kaspar030 · 2015-04-13T09:20:24Z

Mostly.

I take the master branch and then pull in @authmillenon's branch:
# git pull https://github.com/authmillenon/RIOT.git ng_icmpv6/feat/initial
Shouldn't make a difference.
no need to pull ng_tapnet: initial import of a pure Ethernet device for native #2558, this PR includes everything
actually there's no need for bridging. I precreate the tap using openvpn:
# sudo openvpn --mktun --dev tap0
Then setup the linux side of it (e.g., using ip to give it an address)
I start the resulting binary directly:
# <path>/bin/native/driver_netdev_eth.elf tap0

To test pinging,

give the RIOT side an ipv6 address using, e.g., ifconfig <n> add 2001:db8::1/64
add the linux side to the neighbour cache: ```ncache add 2001:db8::2
do the opposite on the Linux side, make sure the tap is UP
ping from Linux side should succeed

kaspar030 · 2015-04-13T09:20:50Z

I've added a patch that makes Linux/RIOT tap MAC addresses different.

jonas-rem · 2015-04-13T11:30:10Z

Ok thx, hope I will find time to test this later.

kaspar030 · 2015-04-13T13:20:11Z

rebased.

jonas-rem · 2015-04-13T23:22:23Z

I can´t set the ipv6 addr using ifconfig. Is there an other dependency that enables setting the IP address using ifconfig via shell interface?

miri64 · 2015-04-14T00:07:09Z

@jremmert-phytec-iot yes, #2581. Sorry, I seem to have missed that in my original mail.

jonas-rem · 2015-04-14T22:55:05Z

@authmillenon guess you meant #2582? But even with #2582 merged I am not able to set an ip address. I get the error: error: unable to add IPv6 address. Haven´t looked deeper into it because I don´t know how to debug native RIOT. I am not familiar with the native RIOT.

@OlegHahm My time to work on this and get used to it is limited. Maybe it would be more effective to assign someone else on this PR. Don´t want to delay the review process.

OlegHahm · 2015-04-15T07:44:21Z

@jremmert-phytec-iot, as always there is no obligation to review a PR. An assignee can always decline and re-assign the PR. Feel free to chose another assignee if you don't have time to work on this.

miri64 · 2015-04-23T13:41:15Z

Needs rebase

jonas-rem · 2015-04-23T14:11:19Z

@authmillenon, would you take over the assignment for this PR? Or is there someone else, that wants to take over the assignment? I haven´t the time to dig deeper into it, sry. Also I have no privileges for a re-assignment.

miri64 · 2015-04-23T14:20:05Z

I think I can do this.

miri64 · 2015-04-25T20:53:27Z

sys/net/link_layer/ng_netdev_eth/ng_netdev_eth.c

+        return -EBADMSG;
+    }
+
+    hdr->type = byteorder_htons(ng_nettype_to_ethertype(pkt->next->type));


Nice to have: add NG_ETHERTYPE_RAW == 0xffff if hdr->type == 0. Otherwise Wireshark shows garbage. Alternatively you can fix ng_nettype_to_ethertype() if this is desired in any case.

miri64 · 2015-05-26T17:32:17Z

Please rebase.

kaspar030 · 2015-05-26T17:36:49Z

Now that #2776 is merged:

rebased

x3ro · 2015-05-26T18:06:52Z

I just tried this out, doing the following:

RIOT:

ifconfig 5 add 2001:db8::1/64

Linux:

brctl addbr br0
ip link set br0 up
sudo openvpn --mktun --dev tap0
ip link set tap0 up
brctl addif br0 tap0
sudo ip -6 address add 2001:db8::2/64 dev br0
ip -6 neigh add 2001:db8::1 lladdr <RIOT Mac> dev br0

Then I started the driver_netdev_eth test and ran ping6 2001:db8::1. The pings were seemingly received, but not responded to, by RIOT (this is from ng_netdev_eth):

ng_netdev_eth: Trigger ISR event
ng_netdev_eth: ISR event [ISR]
ng_netdev_eth: read 86 bytes
ng_netdev_eth: received packet from 06:84:28:54:a8:5e of length 72
000000 33 33 ff 00 00 01 06 84 28 54 a8 5e 86 dd 60 00
000010 00 00 00 20 3a ff 20 01 0d b8 00 00 00 00 00 00
000020 00 00 00 00 00 02 ff 02 00 00 00 00 00 00 00 00
000030 00 01 ff 00 00 01 87 00 46 f2 00 00 00 00 20 01
000040 0d b8 00 00 00 00 00 00 00 00 00 00 00 01 01 01
000050 06 84 28 54 a8 5e
ng_netdev_eth: get [not supported: 5]
ng_netdev_eth: get address

Where should I enable debug output?

miri64 · 2015-05-26T18:12:52Z

ip -6 neigh add 2001:db8::1 lladdr dev br0

What is this line for? It shouldn't be necessary anymore.

As far as I see you still do not configure the interface for forwarding:

sudo sysctl -w net.ipv6.conf.all.forwarding=1

I think this is not enough, but I'm not knowledgable enough in Linux router configuration to say this for sure. Maybe this (Gentoo-centric) link helps: https://wiki.gentoo.org/wiki/IPv6_router_guide

x3ro · 2015-05-26T18:16:35Z

Just testing this PR for now. Wanted to see if the pinging works when I add it to the neighbor cache manually, and then test without adding it. And currently ping doesn't work for me :(

miri64 · 2015-05-26T18:20:50Z

But to the link-local address does, right?

miri64 · 2015-05-26T19:03:25Z

Sorry… I somehow thought I was commenting in #3049 ^^"

miri64 · 2015-05-26T19:03:43Z

But regardless… ping to link-local should work.

…devices

kaspar030 · 2015-05-26T19:07:48Z

rebased, adapted to new THREAD_ defines

miri64 · 2015-05-26T19:18:57Z

Can you squash the eee6de7 into 8dda277, please?

miri64 · 2015-05-26T19:22:08Z

👍

miri64 · 2015-05-26T19:22:55Z

ACK, this PR is well tested for my part.

kaspar030 · 2015-05-26T19:24:14Z

@authmillenon yup.

@x3ro I just tried again.

I added these to the tests Makefile:

USEMODULE += ng_ipv6_default
USEMODULE += ng_ipv6_ext
USEMODULE += ng_icmpv6_echo

Then compiled and started the test using

# sudo bin/native/driver_netdev_eth.elf tap0

Then added a ll address in riot:

> ifconfig 5 add fe80::1234/64

Then configured the linux-side:

# sudo ip link set up dev tap0

Then ping:

[kaspar@localhost riot.7]$ ping6 fe80::1234%tap0
PING fe80::1234%tap0(fe80::1234) 56 data bytes
64 bytes from fe80::1234: icmp_seq=1 ttl=64 time=1.01 ms
^C
--- fe80::1234%tap0 ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 1.015/1.015/1.015/0.000 ms
[kaspar@localhost riot.7]$

kaspar030 · 2015-05-26T19:24:27Z

@authmillenon Should we just merge this? ;)

kaspar030 · 2015-05-26T19:24:53Z

perfect. Go!

sys: net: add netdev device driver using dev_eth low-level ethernet driver API

miri64 · 2015-05-26T19:25:47Z

Ermmm… I would have been comfortable waiting for travis

kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: drivers Area: Device drivers labels Apr 9, 2015

kaspar030 mentioned this pull request Apr 9, 2015

sys: net: add netdev device driver using dev_eth low-level ethernet driver API #2770

Closed

OlegHahm assigned jonas-rem Apr 9, 2015

kaspar030 mentioned this pull request Apr 9, 2015

sys: net: introduce low-level ethernet driver API #2766

Merged

kaspar030 force-pushed the add_dev_eth_netdev2 branch from c4df596 to ac2ddf4 Compare April 12, 2015 07:38

miri64 mentioned this pull request Apr 12, 2015

[SWP] coap plugtests #1801

Closed

kaspar030 force-pushed the add_dev_eth_netdev2 branch from a7ccdc9 to 03cd524 Compare April 13, 2015 13:16

miri64 mentioned this pull request Apr 21, 2015

ng_tapnet: initial import of a pure Ethernet device for native #2558

Closed

1 task

miri64 assigned miri64 and unassigned jonas-rem Apr 23, 2015

OlegHahm mentioned this pull request Apr 25, 2015

shell: add ng_ipv6 support for ifconfig #2582

Merged

miri64 reviewed Apr 25, 2015
View reviewed changes

OlegHahm added this to the Release 2015.06 milestone Apr 29, 2015

kaspar030 force-pushed the add_dev_eth_netdev2 branch from f9bbad0 to e85efd2 Compare May 26, 2015 17:35

kaspar030 removed the State: waiting for other PR State: The PR requires another PR to be merged first label May 26, 2015

kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 26, 2015

sys: net: add ng_netdev_eth netdev driver for dev_eth based ethernet …

1c91bae

…devices

kaspar030 force-pushed the add_dev_eth_netdev2 branch from e85efd2 to eee6de7 Compare May 26, 2015 19:07

tests: add manual test application for netdev_eth

3a7820c

kaspar030 force-pushed the add_dev_eth_netdev2 branch from eee6de7 to 3a7820c Compare May 26, 2015 19:19

kaspar030 added a commit that referenced this pull request May 26, 2015

Merge pull request #2776 from kaspar030/add_dev_eth_netdev2

acd9c14

sys: net: add netdev device driver using dev_eth low-level ethernet driver API

kaspar030 merged commit acd9c14 into RIOT-OS:master May 26, 2015

kaspar030 deleted the add_dev_eth_netdev2 branch May 26, 2015 19:25

This was referenced May 30, 2015

native: txtsnd stops working on OS X after TX/TX one packet #1331

Closed

RFC: split TAP and nativenet #2242

Closed

rfswarm mentioned this pull request Jun 15, 2015

sys: ble: introduce low-level ble driver API #3206

Closed

x3ro mentioned this pull request Jul 18, 2015

Explain how to connect RIOT to Linux #3444

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sys: net: add netdev device driver using dev_eth low-level ethernet driver API #2776

sys: net: add netdev device driver using dev_eth low-level ethernet driver API #2776

kaspar030 commented Apr 9, 2015

kaspar030 commented Apr 9, 2015

kaspar030 commented Apr 12, 2015

jonas-rem commented Apr 13, 2015

kaspar030 commented Apr 13, 2015

kaspar030 commented Apr 13, 2015

jonas-rem commented Apr 13, 2015

kaspar030 commented Apr 13, 2015

jonas-rem commented Apr 13, 2015

miri64 commented Apr 14, 2015

jonas-rem commented Apr 14, 2015

OlegHahm commented Apr 15, 2015

miri64 commented Apr 23, 2015

jonas-rem commented Apr 23, 2015

miri64 commented Apr 23, 2015

miri64 Apr 25, 2015

miri64 commented May 26, 2015

kaspar030 commented May 26, 2015

x3ro commented May 26, 2015

miri64 commented May 26, 2015

x3ro commented May 26, 2015

miri64 commented May 26, 2015

miri64 commented May 26, 2015

miri64 commented May 26, 2015

kaspar030 commented May 26, 2015

miri64 commented May 26, 2015

miri64 commented May 26, 2015

miri64 commented May 26, 2015

kaspar030 commented May 26, 2015

kaspar030 commented May 26, 2015

kaspar030 commented May 26, 2015

miri64 commented May 26, 2015

sys: net: add netdev device driver using dev_eth low-level ethernet driver API #2776

sys: net: add netdev device driver using dev_eth low-level ethernet driver API #2776

Conversation

kaspar030 commented Apr 9, 2015

kaspar030 commented Apr 9, 2015

kaspar030 commented Apr 12, 2015

jonas-rem commented Apr 13, 2015

kaspar030 commented Apr 13, 2015

kaspar030 commented Apr 13, 2015

jonas-rem commented Apr 13, 2015

kaspar030 commented Apr 13, 2015

jonas-rem commented Apr 13, 2015

miri64 commented Apr 14, 2015

jonas-rem commented Apr 14, 2015

OlegHahm commented Apr 15, 2015

miri64 commented Apr 23, 2015

jonas-rem commented Apr 23, 2015

miri64 commented Apr 23, 2015

miri64 Apr 25, 2015

Choose a reason for hiding this comment

miri64 commented May 26, 2015

kaspar030 commented May 26, 2015

x3ro commented May 26, 2015

miri64 commented May 26, 2015

x3ro commented May 26, 2015

miri64 commented May 26, 2015

miri64 commented May 26, 2015

miri64 commented May 26, 2015

kaspar030 commented May 26, 2015

miri64 commented May 26, 2015

miri64 commented May 26, 2015

miri64 commented May 26, 2015

kaspar030 commented May 26, 2015

kaspar030 commented May 26, 2015

kaspar030 commented May 26, 2015

miri64 commented May 26, 2015