Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

drivers: add driver for encx24j600 ethernet chips #2800

Merged
merged 2 commits into from
Sep 5, 2015
Merged

drivers: add driver for encx24j600 ethernet chips #2800

merged 2 commits into from
Sep 5, 2015

Conversation

kaspar030
Copy link
Contributor

This adds a driver for encx24j600 ethernet chips, which are connected through SPI.

Waiting for #3683.

@kaspar030 kaspar030 added Area: network Area: Networking Area: drivers Area: Device drivers labels Apr 13, 2015
@kaspar030
Copy link
Contributor Author

  • fixed some travis static-check complaints

@LudwigKnuepfer LudwigKnuepfer added the State: waiting for other PR State: The PR requires another PR to be merged first label Apr 24, 2015
jautero added a commit to jautero/RIOT that referenced this pull request Apr 27, 2015
@jautero
Merged pull request RIOT-OS#2800
5183b3f
@kaspar030 kaspar030 removed the State: waiting for other PR State: The PR requires another PR to be merged first label May 26, 2015
@kaspar030 kaspar030 force-pushed the add_driver_encx24j600 branch from 4f43e8a to c0dde2b Compare May 26, 2015 17:56
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 26, 2015
@kaspar030
Copy link
Contributor Author

  • squashed, rebased

@kaspar030
Copy link
Contributor Author

Does anyone but me have such a device? If not, would someone ACK based on code review?

@jfischer-no
Copy link
Contributor

@kaspar030 I have order one module from Bulgaria, if you can wait a few more days ... then I can test it.

@kaspar030
Copy link
Contributor Author

Hm, the driver doesn't have many dependencies, so it should be easy to rebase... So I can wait. :)

@kaspar030 kaspar030 mentioned this pull request May 27, 2015
Merged
@kaspar030
Copy link
Contributor Author

Hm, actually I think it would be good to merge this. #3096 can then be changed to support multiple ethernet devices, and also it would make it easier for Elli to use the driver, and they actually paid me to write it.
@jfischer-phytec-iot, would you ACK based on the code without testing and test once you've got the hardware?

@OlegHahm OlegHahm modified the milestone: Release 2015.06 May 28, 2015
@jfischer-no
Copy link
Contributor

Did not forget you :-). Unfortunately not yet had time and my board sticks in "Verzollung"

@jfischer-no
Copy link
Contributor

@kaspar030 please rebase on master

haukepetersen
haukepetersen reviewed Jun 16, 2015
View reviewed changes
drivers/encx24j600/encx24j600.c

enc_spi_transfer(dev, cmd, result, 4);

// DEBUG("encx24j600_reg_get: got 0x%x from register 0x%x\n", (result[2] | (result[3] << 8)), reg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use c style comments
EDIT:
Why comment out DEBUG? Either its not useful -> remove, or comment it in.

@kaspar030
Copy link
Contributor Author

  • rebased

@kaspar030 kaspar030 force-pushed the add_driver_encx24j600 branch from 39856e8 to 82d754b Compare August 25, 2015 14:18
@kaspar030 kaspar030 added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Aug 25, 2015
@kaspar030 kaspar030 force-pushed the add_driver_encx24j600 branch from 82d754b to c2c8c0c Compare August 25, 2015 16:59
@OlegHahm
Copy link
Member

ACK - merge if Travis is fine.

@kaspar030 kaspar030 force-pushed the add_driver_encx24j600 branch 2 times, most recently from a715390 to 0b42731 Compare August 26, 2015 14:13
@kaspar030 kaspar030 added State: waiting for other PR State: The PR requires another PR to be merged first and removed Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 26, 2015
@kaspar030 kaspar030 force-pushed the add_driver_encx24j600 branch from 0b42731 to 777e02f Compare August 26, 2015 17:50
@kaspar030
Copy link
Contributor Author

  • rebased

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Aug 29, 2015
@OlegHahm
Copy link
Member

OlegHahm commented Sep 4, 2015

rebase required again

@OlegHahm OlegHahm removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 4, 2015
@kaspar030 kaspar030 force-pushed the add_driver_encx24j600 branch from 777e02f to 6126147 Compare September 4, 2015 16:04
@kaspar030
Copy link
Contributor Author

  • rebased

@OlegHahm does your ACK hold?

@OlegHahm
Copy link
Member

OlegHahm commented Sep 4, 2015

Yes, please squash!

@kaspar030 kaspar030 force-pushed the add_driver_encx24j600 branch from 6126147 to bd698bf Compare September 4, 2015 16:49
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Sep 5, 2015
@kaspar030
Copy link
Contributor Author

&go.

kaspar030 added a commit that referenced this pull request Sep 5, 2015
@kaspar030
Merge pull request #2800 from kaspar030/add_driver_encx24j600
8bb6f31 
drivers: add driver for encx24j600 ethernet chips
@kaspar030 kaspar030 merged commit 8bb6f31 into RIOT-OS:master Sep 5, 2015
@kaspar030 kaspar030 deleted the add_driver_encx24j600 branch September 5, 2015 15:03
@Dialine
Copy link

Dialine commented Nov 18, 2015

Trying this driver with board from MikroElektronika connected to Atmel Saml21-xpro.
gpio for SPI seems well initialized because during first step of initialization, 0x1234 is read from the device. But the loop waiting 0000 from EUDAST after System Reset never end!
With what board did you test the device from MikroElektronika ?
An idea why System Reset seems not work ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jfischer-no jfischer-no

Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2015.09
Development

Successfully merging this pull request may close these issues.
6 participants
@kaspar030 @jfischer-no @haukepetersen @OlegHahm @Dialine @LudwigKnuepfer