Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ipv6_addr: rename ng_ipv6_hdr_is_ipv6_hdr() to something less silly #2857

Merged
merged 1 commit into from
Apr 25, 2015
Merged

ipv6_addr: rename ng_ipv6_hdr_is_ipv6_hdr() to something less silly #2857

merged 1 commit into from
Apr 25, 2015

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 23, 2015

Suggested in #2454 (comment). Ready for delivery.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. NSTF labels Apr 23, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone Apr 23, 2015
@miri64 miri64 mentioned this pull request Apr 23, 2015
Merged
@OlegHahm
Copy link
Member

How about ng_ipv6_hdr_check() or _verify()?

@miri64
Copy link
Member Author

miri64 commented Apr 23, 2015

I think _is shorter and more to the point of what this function does. _check and _verify sound like way more powerful functions than a lookup of the version field.

@OlegHahm
Copy link
Member

I think the new name sounds weird (actually, I think the best way would be to add something to the coding conventions that allows for is_<MODULE>() function names). However, that's better than the old name and aligned with 6lowpan IIRC.

@miri64
Copy link
Member Author

miri64 commented Apr 25, 2015

So what is your verdict?

@OlegHahm
Copy link
Member

That was a "well, okay then"-ACK.

OlegHahm added a commit that referenced this pull request Apr 25, 2015
@OlegHahm
Merge pull request #2857 from authmillenon/ipv6_addr/enh/rename-hdr-c…
2d8021a 
…heck

ipv6_addr: rename ng_ipv6_hdr_is_ipv6_hdr() to something less silly
@OlegHahm OlegHahm merged commit 2d8021a into RIOT-OS:master Apr 25, 2015
@miri64 miri64 deleted the ipv6_addr/enh/rename-hdr-check branch April 25, 2015 16:08
@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@OlegHahm OlegHahm

Labels
Area: network Area: Networking Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Network Stack Task Force
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @OlegHahm