Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sys: add hwtimer compatibility layer for periph timers #2913

Merged
merged 2 commits into from
May 7, 2015

Conversation

kaspar030
Copy link
Contributor

some platforms don't implement hwtimer_arch directly on timer hardware, but using one periph timer.
In order to reduce code duplication, factor that layer into a module in sys.

This PR also switches samd21 CPU to use this layer.

@kaspar030 kaspar030 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation TimerTaskForce labels May 4, 2015
@kaspar030
Copy link
Contributor Author

I don't like those compatibility layers, but very probably hwtimer will get dropped, anyways.

@haukepetersen haukepetersen self-assigned this May 4, 2015
*
* The hardware timer implementation uses the Cortex build-in system timer as back-end.
* This hwtimer implementation wraps one periph timer
*
* @author Thomas Eichinger <thomas.eichinger@fu-berlin.de>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could put your name in here, as you introduce this module...

@haukepetersen
Copy link
Contributor

Looks good to me, it's up to you if you want to address my comment above... ACK

@kaspar030
Copy link
Contributor Author

Well, I like my name, so I added it. It's still a copy of Thomas' file. :)

@haukepetersen
Copy link
Contributor

No, actually I was the one to write it originally :-) re-ACK, merge when Travis is happy

@LudwigKnuepfer LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 5, 2015
@kaspar030
Copy link
Contributor Author

  • squashed, waiting for travis...

@kaspar030 kaspar030 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 6, 2015
@kaspar030
Copy link
Contributor Author

and GO.

kaspar030 added a commit that referenced this pull request May 7, 2015
sys: add hwtimer compatibility layer for periph timers
@kaspar030 kaspar030 merged commit b0ebdbf into RIOT-OS:master May 7, 2015
@kaspar030 kaspar030 deleted the hwtimer_compat branch May 7, 2015 11:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants