ipv6_netif: fix ng_ipv6_netif_find_best_src_addr() for multicast

[miri64]

Without this fix ng_ipv6_netif_find_best_src_addr() will return :: for most multicast addresses

[Lotterleben]

Do you mean ipv6_net_if_get_best_src_addr? Let me figure out how that happens...

[miri64]

No I mean ng_ipv6_netif_find_best_src_addr()... sorry wrote this from the top of my head and pretty pissed, that I took longer for #3049 than expected :D

[cgundogan]

I also came across this bug several days ago and can confirm it.

[miri64]

Updated the commit message accordingly.

[Lotterleben]

Aaaah that makes much more sense :D

[Lotterleben]

@cgundogan is that also an ACK?

[cgundogan]

@Lotterleben No. Not tested yet (:

[miri64]

And now?

[Lotterleben]

I'd be interested in that too :) I think I understood the problem and the solution looks reasonable to me, but I'm sure @cgundogan has a much more well-informed view on this. I'd merge this fix based on @cgundogan s comment, if that makes sense. (sry, I know youre waiting for this PR but I'm a bit hesistant to merge when I'm unsure I know what I'm doing :D Otherwise we could just reassign to cenk, if thats okay with his workload?)

[cgundogan]

I tested this briefly and it seems to work. Could you also add a quick unittest to tests-ipv6_netif/tests-ipv6_netif.c please? Afterwards, ACK and merge at will

[miri64]

Done.

[miri64]

Wait a minute, I just realized an error in my thinking :D

[miri64]

Will leave this for a follow-up PR.

[Lotterleben]

now i'm confused :D

[miri64]

See #3061