Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: xtimer_msg_receive_timeout: remove timer before ending scope #4883

Merged

Conversation

kaspar030
Copy link
Contributor

Main exits with a stack allocated timer still active, which leads to a hardfault (on samr21).

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 23, 2016
@jnohlgard jnohlgard assigned jnohlgard and unassigned OlegHahm Feb 23, 2016
@jnohlgard
Copy link
Member

Does this fix #4737 for you?

@kaspar030
Copy link
Contributor Author

Ah yes, I wasn't aware of the issue. A weird hardfault after the thread exits was exactly how the bug manifested.

@jnohlgard
Copy link
Member

Fix looks solid, ACK.

@jnohlgard
Copy link
Member

Fixes #4737 on mulle.

@josephnoir
Copy link
Contributor

Yes, fix works on samr21-xpro and arduino-due. ACK.

@OlegHahm OlegHahm added this to the Release 2016.03 milestone Feb 23, 2016
OlegHahm added a commit that referenced this pull request Feb 23, 2016
…timeout

tests: xtimer_msg_receive_timeout: remove timer before ending scope
@OlegHahm OlegHahm merged commit 89ff044 into RIOT-OS:master Feb 23, 2016
@kaspar030 kaspar030 deleted the fix_tests_xtimer_msg_receive_timeout branch February 7, 2017 22:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants