Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

dist/tools/desvirt: proper desvirt integration #5030

Merged
merged 2 commits into from
Mar 10, 2016
Merged

dist/tools/desvirt: proper desvirt integration #5030

merged 2 commits into from
Mar 10, 2016

Conversation

cgundogan
Copy link
Member

This PR integrates desvirt[1] into the RIOT make system.

E.g. for the gnrc_networking example:

TOPO_TYPE=line TOPO_SIZE=4 make desvirt-topology
TOPO=line4 make desvirt-define
make desvirt-list
TOPO=line4 make desvirt-start
nc localhost 4711
ping6 ff02::1
TOPO=line4 make desvirt-stop desvirt-undefine
make desvirt-list
make desvirt-clean (deletes all topology files)

[1] https://github.com/des-testbed/desvirt

depends on des-testbed/desvirt#17
Do not merge before I remove the "DELME" commit.

@cgundogan cgundogan added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first Area: tools Area: Supplementary tools labels Mar 10, 2016
OlegHahm
OlegHahm reviewed Mar 10, 2016
View reviewed changes
dist/tools/desvirt/README.desvirt.md
This Makefile introduces some additional variables:
* TOPO
* TOPO_SIZE
* TOPO_TYPE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An explanation for these variables is missing.

@OlegHahm
Copy link
Member

I think we should add a note on how to connect to these native instances via pyterm -ts.

@cgundogan
Copy link
Member Author

I think we should add a note on how to connect to these native instances via pyterm -ts.

you seem to know more than me on this topic (:
I have to play around with pyterm.

@OlegHahm OlegHahm mentioned this pull request Mar 10, 2016
Merged
@cgundogan cgundogan force-pushed the pr/desvirt/proper_integration branch from b15dc1f to 98958e7 Compare March 10, 2016 17:29
cgundogan
cgundogan reviewed Mar 10, 2016
View reviewed changes
dist/tools/desvirt/README.desvirt.md
```

Once the topology is running, you can use `pyterm` to connect to the various
instances, e.g. calling `pyterm -ts 4712` to connect to node `line4_0` from the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlegHahm should we say that it is also possible to use netcat instead of pyterm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlegHahm actually it's not that important .. and travis already built successfully (:

@cgundogan
Copy link
Member Author

addressed comments

@cgundogan cgundogan removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable State: waiting for other PR State: The PR requires another PR to be merged first labels Mar 10, 2016
@OlegHahm
Copy link
Member

ACK

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 10, 2016
OlegHahm added a commit that referenced this pull request Mar 10, 2016
@OlegHahm
Merge pull request #5030 from cgundogan/pr/desvirt/proper_integration
0ece90b 
dist/tools/desvirt: proper desvirt integration
@OlegHahm OlegHahm merged commit 0ece90b into RIOT-OS:master Mar 10, 2016
@cgundogan cgundogan deleted the pr/desvirt/proper_integration branch March 10, 2016 20:52
@cgundogan
Copy link
Member Author

thanks for the quick review!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@OlegHahm OlegHahm

Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgundogan @OlegHahm