Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

boards/nucleo: removed duplicate features #7964

Merged
merged 3 commits into from
Nov 8, 2017
Merged

boards/nucleo: removed duplicate features #7964

merged 3 commits into from
Nov 8, 2017

Conversation

haukepetersen
Copy link
Contributor

As it seems, some duplicate feature definitions were overlooked in #7241. So this PR removes all features from the nucleo Makefile.features, which are already defined by the (common) CPU implementation.

@haukepetersen haukepetersen added Area: boards Area: Board ports Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Nov 8, 2017
@haukepetersen haukepetersen mentioned this pull request Nov 8, 2017
Merged
@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 8, 2017
aabadie
aabadie approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, maybe the commit messages could be unified:
board/nucleo: remove duplicate feature <feature>

@haukepetersen
Copy link
Contributor Author

maybe not unified, but at least corrected ('remove' vs 'added')...

@haukepetersen
Copy link
Contributor Author

done

kaspar030
kaspar030 approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, didn't we look over the diff together?

ACK.

@aabadie
Copy link
Contributor

aabadie commented Nov 8, 2017

and go!

@aabadie aabadie merged commit 847c4da into RIOT-OS:master Nov 8, 2017
@aabadie aabadie mentioned this pull request Nov 8, 2017
Closed
@haukepetersen haukepetersen deleted the fix_nucleo_features branch November 8, 2017 16:56
@haukepetersen
Copy link
Contributor Author

@kaspar030 yes, we did, but we just looked if stuff was not build anymore that was build before. These left-overs here did not have an influence on the stuff that was build, they simply cluttered the FEATURES_PROVIDED var...

@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

@aabadie aabadie

@kaspar030 kaspar030

Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.
3 participants
@haukepetersen @aabadie @kaspar030