rust: Update nightly version #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what RIOT-OS#204 should have been, but as that nightly build did not contain that day's rustc, the intended version was not installed.
|
This should be the last of the "update nightly to get X" updates. After the 2022.10 release, I'd consider removing nightly from the images altogether; no modules in the ecosystem need nightlies any more, and when users build applications, they pretty please use a local Rust -- see #208. |
|
bors merge |
|
Build succeeded: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what #204 should have been, but as that nightly build did not contain that day's rustc, the intended version was not installed.
I did tests back in #204, but they were about "do they existing things still work", not (what I couldn't test easily back then, as it'd have spanned many crates at once) "does it also have the intended effect of allowing stable use of all the new features".
This unblocks RIOT-OS/rust-riot-wrappers#14, and would have made the rollback of RIOT-OS/RIOT#18642 (comment) unnecessary.