-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
UI: Add MemoryInspector
#111
Draft
AlessioC31
wants to merge
1
commit into
RIP-Comm:main
Choose a base branch
from
AlessioC31:memory_insp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
use emu::{cpu::Cpu, gba::Gba, memory::io_device::IoDevice}; | ||
|
||
use crate::ui_traits::{UiTool, View}; | ||
|
||
use std::{ | ||
borrow::Borrow, | ||
sync::{Arc, Mutex}, | ||
}; | ||
|
||
pub struct MemoryInspector<T: Cpu> { | ||
address_string: String, | ||
value: u8, | ||
base: Base, | ||
gba: Arc<Mutex<Gba<T>>>, | ||
} | ||
|
||
impl<T: Cpu> MemoryInspector<T> { | ||
pub fn new(gba: Arc<Mutex<Gba<T>>>) -> Self { | ||
Self { | ||
gba, | ||
address_string: String::from("0"), | ||
value: 0, | ||
base: Base::Dec, | ||
} | ||
} | ||
} | ||
|
||
impl<T: Cpu> UiTool for MemoryInspector<T> { | ||
fn name(&self) -> &'static str { | ||
"Memory Inspector" | ||
} | ||
|
||
fn show(&mut self, ctx: &egui::Context, open: &mut bool) { | ||
egui::Window::new(self.name()) | ||
.default_width(320.0) | ||
.open(open) | ||
.show(ctx, |ui| { | ||
use View as _; | ||
self.ui(ui); | ||
}); | ||
} | ||
} | ||
|
||
#[derive(PartialEq)] | ||
enum Base { | ||
Dec, | ||
Hex, | ||
} | ||
|
||
impl<T: Cpu> View for MemoryInspector<T> { | ||
fn ui(&mut self, ui: &mut egui::Ui) { | ||
ui.radio_value(&mut self.base, Base::Dec, "Dec"); | ||
ui.radio_value(&mut self.base, Base::Hex, "Hex"); | ||
|
||
ui.horizontal(|ui| { | ||
ui.label("Memory address:"); | ||
ui.text_edit_singleline(&mut self.address_string); | ||
if ui.button("Read").clicked() { | ||
if let Ok(gba) = self.gba.lock() { | ||
let radix = match self.base { | ||
Base::Dec => 10, | ||
Base::Hex => 16, | ||
}; | ||
|
||
let address = u32::from_str_radix(&self.address_string, radix).unwrap(); | ||
self.value = gba.borrow().cpu.get_memory().borrow().read_at(address); | ||
} | ||
} | ||
}); | ||
|
||
ui.label(format!("Value: {}", self.value)); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can return
Rc<RefCell<InternalMemory>>
instead withself.memory.clone()
that returns another usable instance of the Rc. But I don't want to keep it for later, because cpu doesn't need to return the memory, but gba. No problem for now, just a reminder for later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you merge #111 and I rebase this
get_memory
fn will probably go away