Skip to content

Commit

Permalink
Update run_audit.R
Browse files Browse the repository at this point in the history
  • Loading branch information
@cjyetman
cjyetman authored Jan 26, 2025
1 parent 6b2b914 commit 9b0112a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion R/run_audit.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ run_audit <- function(
)

log_debug("Filtering invalid holdings.")
portfolio_total <- dplyr::filter(portfolio_w_flags, .data[[valid_input]] == TRUE)
portfolio_total <- dplyr::filter(portfolio_w_flags, .data[["valid_input"]] == TRUE)

Check warning on line 130 in R/run_audit.R

View workflow job for this annotation

GitHub Actions / R Package Checks / lintr / lint 

file=R/run_audit.R,line=130,col=55,[redundant_equals_linter] Using == on a logical vector is redundant. Well-named logical vectors can be used directly in filtering. For data.table's `i` argument, wrap the column name in (), like `DT[(is_treatment)]`.

Check warning on line 130 in R/run_audit.R

View workflow job for this annotation

GitHub Actions / R Package Checks / lintr / lint 

file=R/run_audit.R,line=130,col=55,[object_usage_linter] no visible binding for global variable '.data'

Check warning on line 130 in R/run_audit.R

View workflow job for this annotation

GitHub Actions / R Package Checks / lintr / lint 

file=R/run_audit.R,line=130,col=81,[line_length_linter] Lines should not be more than 80 characters. This line is 85 characters.

Check warning on line 130 in R/run_audit.R

View check run for this annotation

Codecov / codecov/patch

R/run_audit.R#L129-L130 

Added lines #L129 - L130 were not covered by tests

Check warning on line 131 in R/run_audit.R

View workflow job for this annotation

GitHub Actions / R Package Checks / lintr / lint 

file=R/run_audit.R,line=131,col=1,[trailing_whitespace_linter] Trailing whitespace is superfluous.

# Saving -------------------------------------------------------------------
Expand Down

0 comments on commit 9b0112a

Please # to comment.