Refactor/53 convert to package #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker build status
|
function name is very long when namespaced
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
note to reviewers: This isn't ready to merge yet (RMI-PACTA/pacta.portfolio.audit#46) but it appears to be functional, and would be good to build off of as I work on the input params. In the sprit of not blocking that, there are no exported or documented functions (doing that is tracked as #56) |
|
Finally getting around to reviewing this!! |
jdhoffa
reviewed
May 17, 2024
1 task
cjyetman
reviewed
May 21, 2024
cjyetman
approved these changes
May 21, 2024
This was referenced May 27, 2024
cjyetman
pushed a commit
to RMI-PACTA/workflow.cj.pacta
that referenced
this pull request
Jul 12, 2024
This reverts commit 70a6db1.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert Scripts to functions and restructure repo as R package
closes #53