Conditionally log a DeviceGroupedConvBwdWeightTwoStage_Xdl_CShuffle warning #1860
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanLichtnerAMD
requested review from
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
bartekxk,
andriy-ca and
afagaj
as code owners
JonathanLichtnerAMD
force-pushed
the
jlichtne/SWDEV-511312
branch
2 times, most recently
from
9793c17 to
3001f57
Compare
|
I think instead of ripping out that warning altogether, you should just use the CK_LOGGING environment variable to enable/disable it. |
JonathanLichtnerAMD
force-pushed
the
jlichtne/SWDEV-511312
branch
from
3001f57 to
cc7f295
Compare
JonathanLichtnerAMD
changed the title
Thank you, @illsilin. I've made and tested the change. Please take a look. Thanks! |
illsilin
approved these changes
Feb 11, 2025
…arning The code was emitting a warning if MIOpen did not create a workspace prior to invoking the IsSupportedArgument method, but the condition for MIOpen to create a workspace was not met, and so this condition was not really an error but more of a log message. This commit addresses this issue by using the CK_LOGGING facility to only generate the log message if the CK_LOGGING environment variable is set.
JonathanLichtnerAMD
force-pushed
the
jlichtne/SWDEV-511312
branch
from
cc7f295 to
6a23c15
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was emitting a warning if MIOpen did not create a workspace
prior to invoking the IsSupportedArgument method, but the condition for
MIOpen to create a workspace was not met, and so this condition was not
really an error but more of a log message.
Proposed changes
This commit addresses this issue by using the CK_LOGGING facility to only generate the
log message if the CK_LOGGING environment variable is set.