Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove offload-arch=native in the build #18

Conversation

fxmarty
Copy link

@fxmarty fxmarty commented Nov 6, 2023

Hi,

Hard-coding --offload-arch=native make the build of RoCm flash attention fail in docker build (as I guess GPUs are not accessible during build)

Moreover, this prevents setup.py to obey to the variable PYTORCH_ROCM_ARCH, which is a quite useful feature.

@fxmarty
Copy link
Author

fxmarty commented Nov 6, 2023

cc @sabreshao @howiejayz @fsx950223 what do you think?

Unrelated - I was wondering if you were open to allow issues in this repo? I encountered a few that I think could be nice to report (at least for other users using this repo).

@sabreshao
Copy link
Collaborator

@fxmarty we plan to add an option to resolve docker build. @howiejayz will do that.

@dejay-vu
Copy link

dejay-vu commented Nov 7, 2023

Hi @fxmarty, can you close this PR and move any of your request to issues? I will go through them including this one.

@fxmarty
Copy link
Author

fxmarty commented Nov 7, 2023

Hi @howiejayz happy to do so - however I can't see an issues tab in the repo:

image

@dejay-vu
Copy link

Hi @howiejayz happy to do so - however I can't see an issues tab in the repo:

image

Hi @fxmarty, could you try the latest build_and_run.sh script for building flash-attention in Dockerfile. Also the Issue section is finally opened.

@fxmarty
Copy link
Author

fxmarty commented Nov 29, 2023

Hi @howiejayz, thank you I indeed noticed the available GPU_ARCHS variable, that's working fine now.

Thank you for opening the issue section!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants