Skip to content

Conversation

jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Apr 23, 2024

@jithunnair-amd jithunnair-amd requested a review from WBobby April 23, 2024 21:17
@jithunnair-amd
Copy link
Collaborator Author

@WBobby Please review this change, I wanted to restrict the flag to CentOS7 as compared to original change: 9848db1

@jithunnair-amd jithunnair-amd merged commit b544662 into release/2.1 Apr 24, 2024
pruthvistony pushed a commit that referenced this pull request Apr 27, 2024
…pired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming
pruthvistony pushed a commit that referenced this pull request Apr 30, 2024
…pired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming
jithunnair-amd added a commit that referenced this pull request May 20, 2024
…pired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming
dnikolaev-amd pushed a commit that referenced this pull request Jun 20, 2024
…pired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming
dnikolaev-amd pushed a commit that referenced this pull request Aug 1, 2024
…pired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming
pruthvistony pushed a commit that referenced this pull request Aug 12, 2024
…pired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming
dnikolaev-amd pushed a commit that referenced this pull request Sep 16, 2024
…pired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming
jithunnair-amd pushed a commit that referenced this pull request Oct 11, 2024
===========================================================

Updates to build on Jammy
- Fortran package installation moved after gcc
- Update libtinfo search code in cmake1
- Install libstdc++.so

[UB22.04] Updates to support latest scipy

Build required version of libpng for CentOS7

Updated condition for libstc++ for Jammy

Set ROCM_PATH in env for centOS docker container

Changes to support docker v23

Reversed the condition as required

temporarily ignore certificate check for Miniconda

(cherry picked from commit 9848db1)

[release/2.1] Skip certificate check for CentOS7 since certificate expired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming

Remove the installation of rocm-llvm-dev package

- Causing regression - SWDEV-463083

fix install_centos() function

[rocm6.3_internal_testing] skip pytorch-nightly installstion (#1557)

This PR skips pytorch-nightly installation in docker images

Installation of pytorch-nightly is needed to prefetch mobilenet_v2 avd
v3 models for some tests.
Came from

85bd6bc
Models are downloaded on first use to the folder /root/.cache/torch/hub
But pytorch-nightly installation also overrides
.ci/docker/requirements-ci.txt settings and upgrades some of python
packages (sympy from 1.12.0 to 1.13.0) which causes several
'dynamic_shapes' tests to fail
Skip prefetching models affects these tests without any errors (but
**internet access required**):

- python test/mobile/model_test/gen_test_model.py mobilenet_v2
- python test/quantization/eager/test_numeric_suite_eager.py -k
test_mobilenet_v3

Issue ROCm/frameworks-internal#8772

Also, in case of some issues these models can be prefetched after
pytorch building and before testing

(cherry picked from commit b92b34d)

Fixes #ISSUE_NUMBER
pruthvistony added a commit that referenced this pull request Dec 21, 2024
===========================================================

Updates to build on Jammy
- Fortran package installation moved after gcc
- Update libtinfo search code in cmake1
- Install libstdc++.so

[UB22.04] Updates to support latest scipy

Build required version of libpng for CentOS7

Updated condition for libstc++ for Jammy

Set ROCM_PATH in env for centOS docker container

Changes to support docker v23

Reversed the condition as required

temporarily ignore certificate check for Miniconda

(cherry picked from commit 9848db1)

[release/2.1] Skip certificate check for CentOS7 since certificate expired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming

Remove the installation of rocm-llvm-dev package

- Causing regression - SWDEV-463083

fix install_centos() function

[rocm6.3_internal_testing] skip pytorch-nightly installstion (#1557)

This PR skips pytorch-nightly installation in docker images

Installation of pytorch-nightly is needed to prefetch mobilenet_v2 avd
v3 models for some tests.
Came from

85bd6bc
Models are downloaded on first use to the folder /root/.cache/torch/hub
But pytorch-nightly installation also overrides
.ci/docker/requirements-ci.txt settings and upgrades some of python
packages (sympy from 1.12.0 to 1.13.0) which causes several
'dynamic_shapes' tests to fail
Skip prefetching models affects these tests without any errors (but
**internet access required**):

- python test/mobile/model_test/gen_test_model.py mobilenet_v2
- python test/quantization/eager/test_numeric_suite_eager.py -k
test_mobilenet_v3

Issue ROCm/frameworks-internal#8772

Also, in case of some issues these models can be prefetched after
pytorch building and before testing

(cherry picked from commit b92b34d)

Fixes #ISSUE_NUMBER
jithunnair-amd added a commit that referenced this pull request Mar 17, 2025
…pired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming
dnikolaev-amd pushed a commit that referenced this pull request Apr 24, 2025
===========================================================

Updates to build on Jammy
- Fortran package installation moved after gcc
- Update libtinfo search code in cmake1
- Install libstdc++.so

[UB22.04] Updates to support latest scipy

Build required version of libpng for CentOS7

Updated condition for libstc++ for Jammy

Set ROCM_PATH in env for centOS docker container

Changes to support docker v23

Reversed the condition as required

temporarily ignore certificate check for Miniconda

(cherry picked from commit 9848db1)

[release/2.1] Skip certificate check for CentOS7 since certificate expired (#1399)

* Skip certificate check only for CentOS7 since certificate expired

* Naming

Remove the installation of rocm-llvm-dev package

- Causing regression - SWDEV-463083

fix install_centos() function

[rocm6.3_internal_testing] skip pytorch-nightly installstion (#1557)

This PR skips pytorch-nightly installation in docker images

Installation of pytorch-nightly is needed to prefetch mobilenet_v2 avd
v3 models for some tests.
Came from

85bd6bc
Models are downloaded on first use to the folder /root/.cache/torch/hub
But pytorch-nightly installation also overrides
.ci/docker/requirements-ci.txt settings and upgrades some of python
packages (sympy from 1.12.0 to 1.13.0) which causes several
'dynamic_shapes' tests to fail
Skip prefetching models affects these tests without any errors (but
**internet access required**):

- python test/mobile/model_test/gen_test_model.py mobilenet_v2
- python test/quantization/eager/test_numeric_suite_eager.py -k
test_mobilenet_v3

Issue ROCm/frameworks-internal#8772

Also, in case of some issues these models can be prefetched after
pytorch building and before testing

(cherry picked from commit b92b34d)

Fixes #ISSUE_NUMBER

(cherry picked from commit ec70f7e)

[rocm6.4_internal_testing] Changes to support UB 24.04 build (#1817)

Changes applied from #1816

Test PyTorch build:
http://rocm-ci.amd.com/job/mainline-framework-pytorch-ub24.04-py312-internal/5/

(cherry picked from commit 74e1e9e)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant