Skip to content

Enable rocSolver for batch eigen decomposition on ROCm #2148

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: rocm6.5_internal_testing
Choose a base branch
from

Conversation

dnikolaev-amd
Copy link

@dnikolaev-amd dnikolaev-amd commented May 14, 2025

WIP
Need to clarify JIRA scope first
Fixes SWDEV-531961

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented May 14, 2025

Jenkins build for 377466bc2584aa1afa3537aa195e1be731923afe commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Detected error during Pytorch building:

[5427/7991] Building CXX object third_party/ideep/mkl-dnn/src/graph/backend/dnnl/CMakeFiles/dnnl_graph_backend_dnnl.dir/kernels/eltwise.cpp.o
[5428/7991] Building CXX object third_party/ideep/mkl-dnn/src/cpu/x64/CMakeFiles/dnnl_cpu_x64.dir/jit_uni_dw_conv_kernel_f32.cpp.o
[5429/7991] Building CXX object third_party/ideep/mkl-dnn/src/graph/backend/dnnl/CMakeFiles/dnnl_graph_backend_dnnl.dir/kernels/group_norm.cpp.o
[5430/7991] Building CXX object third_party/ideep/mkl-dnn/src/graph/backend/dnnl/CMakeFiles/dnnl_graph_backend_dnnl.dir/kernels/matmul.cpp.o
[5431/7991] Building CXX object third_party/kineto/libkineto/CMakeFiles/kineto_base.dir/src/RocLogger.cpp.o
FAILED: third_party/kineto/libkineto/CMakeFiles/kineto_base.dir/src/RocLogger.cpp.o 
/opt/cache/bin/sccache /opt/cache/bin/c++ -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MMAP=1 -DHAVE_SHM_OPEN=1 -DHAVE_SHM_UNLINK=1 -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DROCM_VERSION=60400 -DTORCH_ENABLE_LLVM -DTORCH_HIP_VERSION=604 -DUSE_EXTERNAL_MZCRC -D_FILE_OFFSET_BITS=64 -I/opt/rocm-6.4.0/include -I/var/lib/jenkins/pytorch/cmake/../third_party/benchmark/include -I/opt/llvm/include -I/var/lib/jenkins/pytorch/third_party/onnx -I/var/lib/jenkins/pytorch/build/third_party/onnx -I/var/lib/jenkins/pytorch/third_party/kineto/libkineto/include -I/var/lib/jenkins/pytorch/third_party/kineto/libkineto/src -I/var/lib/jenkins/pytorch/third_party/kineto/libkineto/third_party/dynolog -I/var/lib/jenkins/pytorch/third_party/fmt/include -I/var/lib/jenkins/pytorch/third_party/kineto/libkineto/third_party/dynolog/dynolog/src/ipcfabric -I/extras/CUPTI/include -I/include -I/opt/rocm/include/roctracer -I/opt/rocm/include -isystem /var/lib/jenkins/pytorch/build/third_party/gloo -isystem /var/lib/jenkins/pytorch/cmake/../third_party/gloo -isystem /var/lib/jenkins/pytorch/cmake/../third_party/tensorpipe/third_party/libuv/include -isystem /var/lib/jenkins/pytorch/cmake/../third_party/googletest/googlemock/include -isystem /var/lib/jenkins/pytorch/cmake/../third_party/googletest/googletest/include -isystem /var/lib/jenkins/pytorch/third_party/protobuf/src -isystem /opt/conda/envs/py_3.12/include -isystem /var/lib/jenkins/pytorch/third_party/XNNPACK/include -isystem /var/lib/jenkins/pytorch/third_party/ittapi/include -isystem /var/lib/jenkins/pytorch/cmake/../third_party/eigen -isystem /var/lib/jenkins/pytorch/third_party/ideep/mkl-dnn/include/oneapi/dnnl -isystem /var/lib/jenkins/pytorch/third_party/ideep/include -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -O3 -DNDEBUG -DNDEBUG -std=c++17 -fPIC -DMKL_HAS_SBGEMM -D__HIP_PLATFORM_AMD__=1 -DTORCH_USE_LIBUV -DCAFFE2_USE_GLOO -DHAS_ROCTRACER -D__HIP_PLATFORM_AMD__ -DKINETO_NAMESPACE=libkineto -DFMT_HEADER_ONLY -DENABLE_IPC_FABRIC -std=c++17 -MD -MT third_party/kineto/libkineto/CMakeFiles/kineto_base.dir/src/RocLogger.cpp.o -MF third_party/kineto/libkineto/CMakeFiles/kineto_base.dir/src/RocLogger.cpp.o.d -o third_party/kineto/libkineto/CMakeFiles/kineto_base.dir/src/RocLogger.cpp.o -c /var/lib/jenkins/pytorch/third_party/kineto/libkineto/src/RocLogger.cpp
In file included from /var/lib/jenkins/pytorch/third_party/kineto/libkineto/src/RocLogger.cpp:9:
/var/lib/jenkins/pytorch/third_party/kineto/libkineto/src/RocLogger.h:227:15: error: field ‘kernelName’ has incomplete type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’}
  227 |   std::string kernelName;
      |               ^~~~~~~~~~

Copy link
Collaborator

@pruthvistony pruthvistony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you raise upstream PR for this, please add profiling results.

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented May 14, 2025

Jenkins build for 377466bc2584aa1afa3537aa195e1be731923afe commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@pruthvistony pruthvistony requested a review from jeffdaily May 14, 2025 17:34
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented May 14, 2025

Jenkins build for 377466bc2584aa1afa3537aa195e1be731923afe commit finished as ABORTED
Links: Blue Ocean view / Build artifacts

@dnikolaev-amd dnikolaev-amd force-pushed the enable_rocsolver_for_batch_eigen_decomposition_on_rocm branch from 377466b to ef4c3d3 Compare May 28, 2025 14:37
@rocm-repo-management-api
Copy link

Jenkins build for ef4c3d3e50aae11c7a89b67bbd2b59011489d380 commit is in progress
Links: Blue Ocean view / Build artifacts

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants