Moved git-hash determination to passed in build variable #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @XECDesign, could we merge this PR to better support building under docker (without git repo access)? |
|
Thank you |
fuji246
pushed a commit
to lomorage/pi-gen
that referenced
this pull request
Sep 17, 2019
PeterJohnson
pushed a commit
to PeterJohnson/WPILibPi
that referenced
this pull request
Dec 7, 2019
general-wedge
pushed a commit
to HQapp/hq-os
that referenced
this pull request
Jan 5, 2020
alexgg
pushed a commit
to balena-os/pi-gen
that referenced
this pull request
Jul 12, 2021
UmeshMohan-Dozee
pushed a commit
to DozeeRnD/pi-gen
that referenced
this pull request
Sep 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes trying to retrieve the HEAD commit hash during the build stages themselves which can fail under certain circumstances using docker in a git submodule. (See #180 (comment)).