Adds instructions and works on linux as well #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saharNooby
requested changes
Apr 3, 2023
README.md
Outdated
| @@ -31,20 +31,25 @@ cmake --build . --config Release | |||
|
|
|||
| If everything went OK, `bin\Release\rwkv.dll` file should appear. | |||
|
|
|||
| ### 2. Download an RWKV model from [Hugging Face](https://huggingface.co/BlinkDL) and convert it into `ggml` format | |||
|
|
|||
| ### 2. Download an RWKV model from [Hugging Face](https://huggingface.co/BlinkDL) like [this one](https://huggingface.co/BlinkDL/rwkv-4-pile-169m/blob/main/RWKV-4b-Pile-171M-20230202-7922.pth) and convert it into `ggml` format | |||
There was a problem hiding this comment.
Use RWKV-4 models (NOT RWKV-4a, NOT RWKV-4b) unless you know what you are doing.
4a and 4b models are experiments containing new model parts, and will not work good with rwkv.cpp. Please change links and file names below to use regular 4 model, not 4b :)
README.md
Outdated
| @@ -75,9 +88,13 @@ Example of using `rwkv.cpp` in your custom Python script: | |||
| import rwkv_cpp_model | |||
| import rwkv_cpp_shared_library | |||
|
|
|||
| # change by model paths used above (quantized or full weights) | |||
There was a problem hiding this comment.
Suggested change
| # change by model paths used above (quantized or full weights) | |
| # Change to model paths used above (quantized or full weights) |
rwkv/chat_with_bot.py
Outdated
| import sys | ||
| import argparse | ||
| import sampling | ||
| import tokenizers | ||
| import rwkv_cpp_model | ||
| import rwkv_cpp_shared_library | ||
| from pathlib import Path |
There was a problem hiding this comment.
I would prefer to use import pathlib and pathlib.Path below for style consistency
saharNooby
approved these changes
Apr 3, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates instructions and works on linux as well. Still couldnt get it to work on Mac M1 due to arm vs x86 mismatch.