Transform access to Rule/Root #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadValentin
reviewed
Jun 16, 2022
RadValentin
requested changes
Jun 16, 2022
There was a problem hiding this comment.
Looks good, left one comment. Let's not introduce any breaking changes in this PR, instead I'll make a note to look at dropping root.source.input.file as part of PostCSS 8 upgrade #95 . Feel free to update the readme to mention the new rule argument.
|
@RadValentin Separated tests and added a bit to README. Let me know if I can do anything else here. |
|
Published v1.16.0 which includes the changes in this PR, thanks for contributing! |
|
My pleasure! 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #108 we discussed getting access to the raw postcss Root in the transform callback. While I was working on this I realized that you can get Root from a Rule (Rule#root). Giving the user access to the current Rule therefor opens up even more options.
I have added tests that also demonstrate why this feature is useful.
If you don't mind making a breaking change I would consider removing this line: https://github.com/luttje/postcss-prefix-selector/blob/c61250e46d63f34913702253f076de72a0daa730/index.js#L47 Since that can now be reached through
rule.root.source.input.fileLet me know if I need to add/change something. If you think it's all good, let me know and I'll add a bit of explanation to the README as well.