platform: add radxa rock 5b+ support #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nascs <nascs@radxa.com>
Signed-off-by: Nascs <nascs@radxa.com>
Signed-off-by: Nascs <nascs@radxa.com>
Signed-off-by: Nascs <nascs@radxa.com>
|
5B+ 的 PIN_29 和 PIN_31 与 5B 有区别，详见 radxa-docs/docs#338 |
Signed-off-by: Nascs <nascs@radxa.com>
Signed-off-by: Nascs <nascs@radxa.com>
Signed-off-by: Nascs <nascs@radxa.com>
|
功能测试 ok |
nascs
commented
Jul 19, 2024
| if(b->platform_name == PLATFORM_NAME_RADXA_ROCK_5B) { | ||
| mraa_radxa_rock_5b_pininfo(b, 29, 1, 31, (mraa_pincapabilities_t){1,1,1,0,0,0,0,0}, "GPIO1_D7"); | ||
| mraa_radxa_rock_5b_pininfo(b, 31, 1, 15, (mraa_pincapabilities_t){1,1,1,0,0,0,0,0}, "GPIO1_B7"); | ||
| mraa_radxa_rock_5b_pininfo(b, 37, -1, -1, (mraa_pincapabilities_t){1,0,0,0,0,0,1,0}, "NC"); |
There was a problem hiding this comment.
5B PIN_37 这里 NC 是因为硬件要么没接出来要么是没贴电阻。
There was a problem hiding this comment.
上面的pinout和我们文档有更新么？我还是第一次知道这个
nascs
commented
Jul 19, 2024
| mraa_radxa_rock_5b_pininfo(b, 31, 1, 15, (mraa_pincapabilities_t){1,1,1,0,0,0,0,0}, "GPIO1_B7"); | ||
| mraa_radxa_rock_5b_pininfo(b, 37, -1, -1, (mraa_pincapabilities_t){1,0,0,0,0,0,1,0}, "NC"); | ||
| } else if(b->platform_name == PLATFORM_NAME_RADXA_ROCK_5B_PLUS) { | ||
| mraa_radxa_rock_5b_pininfo(b, 29, 1, 3, (mraa_pincapabilities_t){1,1,1,0,0,1,0,0}, "GPIO1_A3"); |
There was a problem hiding this comment.
PIN_29 PWM1-M2, 板级打开了 PWM1-M0 这里关闭 PWM?
|
这个 pr 没找到 request for review 按钮，有空 review 一下？ |
RadxaYuntian
requested changes
Jul 25, 2024
Comment on lines
54
to
+55
| * [Radxa ROCK 5B](../master/docs/radxa_rock_5b.md) | ||
| * [Radxa ROCK 5B+](../master/docs/radxa_rock_5b.md) |
| - [Github](https://github.com/radxa) |
| @@ -152,7 +173,7 @@ mraa_radxa_rock_5b() | |||
| mraa_radxa_rock_5b_pininfo(b, 12, 3, 13, (mraa_pincapabilities_t){1,1,1,0,0,0,0,1}, "GPIO3_B5"); | |||
| mraa_radxa_rock_5b_pininfo(b, 13, 3, 15, (mraa_pincapabilities_t){1,1,0,0,1,1,0,0}, "GPIO3_B7"); | |||
| mraa_radxa_rock_5b_pininfo(b, 14, -1, -1, (mraa_pincapabilities_t){1,0,0,0,0,0,0,0}, "GND"); | |||
| mraa_radxa_rock_5b_pininfo(b, 15, 3, 16, (mraa_pincapabilities_t){1,0,0,0,1,1,0,1}, "GPIO3_C0"); | |||
| mraa_radxa_rock_5b_pininfo(b, 15, 3, 16, (mraa_pincapabilities_t){1,1,0,0,1,1,0,1}, "GPIO3_C0"); | |||
| if(b->platform_name == PLATFORM_NAME_RADXA_ROCK_5B) { | ||
| mraa_radxa_rock_5b_pininfo(b, 29, 1, 31, (mraa_pincapabilities_t){1,1,1,0,0,0,0,0}, "GPIO1_D7"); | ||
| mraa_radxa_rock_5b_pininfo(b, 31, 1, 15, (mraa_pincapabilities_t){1,1,1,0,0,0,0,0}, "GPIO1_B7"); | ||
| mraa_radxa_rock_5b_pininfo(b, 37, -1, -1, (mraa_pincapabilities_t){1,0,0,0,0,0,1,0}, "NC"); |
There was a problem hiding this comment.
上面的pinout和我们文档有更新么？我还是第一次知道这个
| mraa_radxa_rock_5b_pininfo(b, 31, 1, 15, (mraa_pincapabilities_t){1,1,1,0,0,0,0,0}, "GPIO1_B7"); | ||
| mraa_radxa_rock_5b_pininfo(b, 37, -1, -1, (mraa_pincapabilities_t){1,0,0,0,0,0,1,0}, "NC"); | ||
| } else if(b->platform_name == PLATFORM_NAME_RADXA_ROCK_5B_PLUS) { | ||
| mraa_radxa_rock_5b_pininfo(b, 29, 1, 3, (mraa_pincapabilities_t){1,1,1,0,0,1,0,0}, "GPIO1_A3"); |
| @@ -1052,7 +1052,7 @@ mraa_file_contains(const char* filename, const char* content) | |||
| return 0; | |||
| } | |||
| while ((getline(&line, &len, fh) != -1) && (found == 0)) { | |||
| if (strstr(line, content)) { | |||
| if (strncmp(line, content, strlen(line)) == 0) { | |||
Co-authored-by: ZHANG Yuntian <yt@radxa.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
周一测