Default to no EPR/PPS so its opt in #2073
Conversation
Some chargers have funky PPS. Plus some do not want EPR be default (even though 28V is safe by designer on PinecilV2). So take the safest option by default and make it opt-in
There was a problem hiding this comment.
Just my own humble two cents...
Probably it will be worth mentioning somewhere in the docs, so I will try not to forget to address this in the future.
I understand the risk having this on by default, but one of the main features (not available with any other supported hardware) is full EPR/28V mode support, but having this off by default will probably raise a lot of questions from freshly new users who is getting Pinecil V2 for this reason only. :/
| @@ -93,7 +93,7 @@ static const SettingConstants settingsConstants[(int)SettingsOptions::SettingsOp | |||
| { 0, 6, 1, 1}, // LOGOTime | |||
| { 0, 1, 1, 0}, // CalibrateCJC | |||
| { 0, 1, 1, 0}, // BluetoothLE | |||
| { 0, 2, 1, 1}, // USBPDMode | |||
| { 0, 2, 1, 0}, // USBPDMode | |||
There was a problem hiding this comment.
Interesting... Definitely looks more safer, especially when users connect PD-compatible supported hardware to not-so-reliable PD-kinda power sources.
|
Yeah it's a trade off, between safest and what people expect. |
Some chargers have funky PPS.
Plus some do not want EPR be default (even though 28V is safe by designer on PinecilV2).
So take the safest option by default and make it opt-in
Request from Pinecil Chat - dsimic
What is the new behavior (if this is a feature change)?
Other information: