adding npm script to clang-format generated files #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nertpinx
approved these changes
Jul 26, 2018
| "check:libvirt_api_xml": "node tools/api_xml_files.js", | ||
| "check:libvirt_min_ver": "node tools/check_min_libvirt_ver.js", | ||
| "check": "npm run check:libvirt_min_ver & npm run check:libvirt_api_xml" | ||
| "check:libvirt_min_ver": "node tools/check_min_libvirt_ver.js" |
There was a problem hiding this comment.
This is a small enough hunk on which it is easy to show what I meant by commit separation. One commit should be the reordering of check and check:libvirt_min_ver targets (trivial, push it right away) and yet another one should be the addition of the formatting. With bigger patches it goes very ugly very fast when you are looking at which patch broke something.
There was a problem hiding this comment.
agreed, split the patch, thanks
RamyElkest
force-pushed
the
clang-format
branch
from
1a2a0df to
e7c08ef
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.