-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Python_functional_parameters #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
…gamaniLabUCSD/Mem3DG into python_functional_parameters
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
ctlee
previously approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too big to review closely. Things look ok.
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Offload some complex parameter input to python by binding to std::function
Todos
Notable points that this PR has either accomplished or will accomplish.
center
(now callednotableVertex
) asa surfacePointa boolean Eigen vector with length of the number of vertices. Effectively constrain the type of notable element to be vertex only.notableVertex
: 1)getVertexClosestToEmbeddedCoordinate()
based on Euclidean distance, and 2)getVertexFurthestFromBoundary()
based on geodesic distance.notableVertex
in trajectory both in .ply and .nc and read in the if simulation continuation with NetCDF.Use 1) time, 2) parameter form and 3) whether receive center in System initializer to decide wether prescribe in init(). Actually solely on whether receive center, if not receive center and no form, throw message and set default, when closed, set index = 0, when boundary, set center of boundary loopGeometry()
takes in an explicitstd::size_t
argument to define the initialnotableVertex
, which defaults to the vertex with index 0. Expect user to use the utility functions described above to find the index of a special geometric vertex.point
tonotatioin element or centernotableVertex
Status