Switching to standard Helfrich #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
…tation Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
ctlee
added a commit
that referenced
this pull request
Apr 12, 2024
* Update issue templates (#66) * chore: add bug report and feature issue templates * Support for auto copyright processing (#67) * chore: Add automatic copyright processing scripts Borrowed from GROMACS. Headers are updated accordingly. * Switching to standard Helfrich (#65) * refactor: Refactor convergence test printing * test: Add roller boundary test example * chore: bump geometry-central to latest * feat: Add back pure Gaussian term. Also restoring deviatoric implementation * refactor: Add Kg and Kgc to python api * style: Fix typo in boilerplate * refactor: Move updateconfiguration into updatePrescription * refactor: change backtracking to test with updated timestep --------- Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we used a non-standard form of the Helfrich energy which is related to the broader literature by a factor of two. To prevent mistakes in assigning parameters from the broader literature we have switched to follow the form of the original Helfrich equation.
Before:
$E_b = \int_{\mathcal{M}}\left[\kappa(H-\bar{H})^{2}+\kappa_{G} K\right] dA.$
After:
$E_b = \int_{\mathcal{M}}\left[2\kappa(H-\bar{H})^{2}+\kappa_{G} K\right] dA.$
This PR also adds some additional convenience features and restores the conventional contribution from the Gaussian curvature term.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
N/A
Status