Remove unused function operator<<(std::ostream& out, const vec3& v)
#1495
Assignees
Milestone
Comments
hollasch
added a commit
that referenced
this issue
Apr 15, 2024
When I created issue #1495, I must have been in the middle of a code progression, because it appeared to me that vec3::operator<< was unused. Turns out it _is_ used, in debug code for the `constant_medium::hit()` function. This code was created as a clean-up for the original scattered debug statements in this function. On review, however, this appears a bit odd, as the text does not mention the debuggability option (it's off by default), and no other code in the books has debug print code. Looking at it again, I think it should be removed, and readers are free to add whatever debug code they need at any stage in development. Resolves #1495
hollasch
added a commit
that referenced
this issue
Apr 16, 2024
When I created issue #1495, I must have been in the middle of a code progression, because it appeared to me that vec3::operator<< was unused. Turns out it _is_ used, in debug code for the `constant_medium::hit()` function. This code was created as a clean-up for the original scattered debug statements in this function. On review, however, this appears a bit odd, as the text does not mention the debuggability option (it's off by default), and no other code in the books has debug print code. Looking at it again, I think it should be removed, and readers are free to add whatever debug code they need at any stage in development. Resolves #1495
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Perhaps we'd defined this for color output, but we don't use it.
The text was updated successfully, but these errors were encountered: