Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The Rest: Listing 10 missing parentheses in translate constructor #603

Closed
D-K-E opened this issue May 19, 2020 · 1 comment
Closed

The Rest: Listing 10 missing parentheses in translate constructor #603

D-K-E opened this issue May 19, 2020 · 1 comment
Assignees
@hollasch
Labels
area: book book 3: Your Life
Milestone
v3.1.2

Comments

@D-K-E
Copy link

D-K-E commented May 19, 2020

The listing 10 in the book The Rest of Your Life lacks the last parentheses in the translate constructor.

    shared_ptr<hittable> box2 = make_shared<box>(point3(0,0,0), point3(165,165,165), white);
    box2 = make_shared<rotate_y>(box2, -18);
    box2 = make_shared<translate>(box2, vec3(130,0,65);

should be corrected to

box2 = make_shared<translate>(box2, vec3(130,0,65));
hollasch added a commit that referenced this issue May 19, 2020
@hollasch
Add missing parenthesis in book 3 listing 10
40f13bb 
Resolves #603
@hollasch hollasch self-assigned this May 19, 2020
@hollasch hollasch added this to the v3.1.2 milestone May 19, 2020
@hollasch
Copy link
Collaborator

Fixed in dev-patch branch for next patch/minor release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@hollasch hollasch

Labels
area: book book 3: Your Life
Projects
None yet
Milestone
v3.1.2
Development

No branches or pull requests
2 participants
@hollasch @D-K-E