-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(Change package name): Change provider package names #3846
base: dev
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Looks like we will need a bit more memory for builds, hopefully not linear to the amount of extension projects. |
After trying the Facebook released Dec 2023 and it still failed, I noticed that issue does not affect Facebook itself but instead a patched app fails to install along side it's original if it has any any exported providers in the manifest. Using this PR I could install that specific app twice using change package name, and without this PR it fails to install the second installation. |
PS: Decoding is handled by Androlib by ApkTool. So this issue should be mentioned there. |
It appears this change can break embedded usage of other apps, such as Facebook integration within an app. This change should be a patch option that is default off. The option should explain that enabling it can fix installation issues if the patched app fails to install, but the option can break some in app features. |
In which app have you observed this behavior? Maybe that's fixable
Agreed |
cdcfb69
to
15d8d41
Compare
I have not confirmed, but with Facebook if the provider is renamed then I believe Facebook integration will be broken because the renamed package name is not a valid facebook id:
Both of the new options should explain that enabling the feature can fix installation errors but can break some in app features. |
c0cd9d2
to
2ace07d
Compare
15d8d41
to
3e02292
Compare
The existing
Change package name
patch only renames the package attribute of the manifest. If encountered some problems while trying to use it to clone the Mega.nz app, due to its use of providers and theDYNAMIC_RECEIVER_NOT_EXPORTED_PERMISSION
permission, so I extended the patch to also update those.Cloning Mega seems to work now, although I'm not entirely sure if there are any problems at runtime due to the renamed provider authorities